Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLib] Crash opening webkit://gpu when XDG_CURRENT_DESKTOP is undefined #12314

Merged
merged 1 commit into from Apr 3, 2023
Merged

[GLib] Crash opening webkit://gpu when XDG_CURRENT_DESKTOP is undefined #12314

merged 1 commit into from Apr 3, 2023

Conversation

aperezdc
Copy link
Contributor

@aperezdc aperezdc commented Apr 3, 2023 •
edited by webkit-early-warning-system

6a3c071

[GLib] Crash opening webkit://gpu when XDG_CURRENT_DESKTOP is undefined
https://bugs.webkit.org/show_bug.cgi?id=254913

Reviewed by Philippe Normand.

* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU): Check whether picking
XDG_CURRENT_DESKTOP from the environment returns non-null and the
variable is not empty before using it.

Canonical link: https://commits.webkit.org/262504@main

4e4de87

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@aperezdc aperezdc requested a review from a team as a code owner April 3, 2023 12:35
@aperezdc aperezdc self-assigned this Apr 3, 2023
@aperezdc aperezdc added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Apr 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4e4de87)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 3, 2023
@aperezdc
[GLib] Crash opening webkit://gpu when XDG_CURRENT_DESKTOP is undefined
6a3c071 
https://bugs.webkit.org/show_bug.cgi?id=254913

Reviewed by Philippe Normand.

* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU): Check whether picking
XDG_CURRENT_DESKTOP from the environment returns non-null and the
variable is not empty before using it.

Canonical link: https://commits.webkit.org/262504@main
@webkit-commit-queue
Copy link
Collaborator

Committed 262504@main (6a3c071): https://commits.webkit.org/262504@main

Reviewed commits have been landed. Closing PR #12314 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6a3c071 into WebKit:main Apr 3, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 3, 2023
@aperezdc aperezdc deleted the eng/getenvnullcheck branch April 3, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philn philn philn approved these changes

@carlosgcampos carlosgcampos Awaiting requested review from carlosgcampos

Assignees

@aperezdc aperezdc

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@aperezdc @webkit-early-warning-system @webkit-commit-queue @philn