Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify HTMLFastPathParser::scanEscapedAttributeValue() #12327

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 3, 2023

a740a0c

Simplify HTMLFastPathParser::scanEscapedAttributeValue()
https://bugs.webkit.org/show_bug.cgi?id=254929

Reviewed by Ryosuke Niwa.

Simplify HTMLFastPathParser::scanEscapedAttributeValue():
- Do an early return to avoid nesting
- Drop `result` & `start` variables as they were initialized but never used
- Merge 2 if conditions now that they're one after the other

* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::scanEscapedAttributeValue):

Canonical link: https://commits.webkit.org/262531@main

5d5d74e

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
  πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@cdumez cdumez self-assigned this Apr 3, 2023
@cdumez cdumez added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Apr 3, 2023
@cdumez cdumez force-pushed the 254929_simplify_scanEscapedAttributeValue branch from 92c42f3 to 3bc0f5d Compare April 3, 2023 18:38
@cdumez cdumez force-pushed the 254929_simplify_scanEscapedAttributeValue branch from 3bc0f5d to 9bfc9fd Compare April 3, 2023 18:54
@cdumez cdumez marked this pull request as ready for review April 3, 2023 19:00
@cdumez cdumez requested a review from rniwa as a code owner April 3, 2023 19:00
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 3, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Apr 3, 2023
@cdumez cdumez force-pushed the 254929_simplify_scanEscapedAttributeValue branch from 9bfc9fd to ca37a88 Compare April 3, 2023 19:57
@cdumez cdumez force-pushed the 254929_simplify_scanEscapedAttributeValue branch from ca37a88 to 5d5d74e Compare April 3, 2023 20:39
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=254929

Reviewed by Ryosuke Niwa.

Simplify HTMLFastPathParser::scanEscapedAttributeValue():
- Do an early return to avoid nesting
- Drop `result` & `start` variables as they were initialized but never used
- Merge 2 if conditions now that they're one after the other

* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::scanEscapedAttributeValue):

Canonical link: https://commits.webkit.org/262531@main
@webkit-commit-queue webkit-commit-queue force-pushed the 254929_simplify_scanEscapedAttributeValue branch from 5d5d74e to a740a0c Compare April 3, 2023 21:58
@webkit-commit-queue
Copy link
Collaborator

Committed 262531@main (a740a0c): https://commits.webkit.org/262531@main

Reviewed commits have been landed. Closing PR #12327 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a740a0c into WebKit:main Apr 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
6 participants