Unreviewed, address post-landing review feedback from Darin for 262531@main #12346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
DOM
cdumez
referenced
this pull request
Apr 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=254929 Reviewed by Ryosuke Niwa. Simplify HTMLFastPathParser::scanEscapedAttributeValue(): - Do an early return to avoid nesting - Drop `result` & `start` variables as they were initialized but never used - Merge 2 if conditions now that they're one after the other * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::scanEscapedAttributeValue): Canonical link: https://commits.webkit.org/262531@main
|
EWS run on current version of this PR (hash 879f609)
|
…1@main https://bugs.webkit.org/show_bug.cgi?id=254955 rdar://107583254 * Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp: (WebCore::HTMLFastPathParser::scanAttributeValue): (WebCore::HTMLFastPathParser::scanEscapedAttributeValue): Canonical link: https://commits.webkit.org/262548@main
webkit-commit-queue
force-pushed
the
eng/Unreviewed-address-post-landing-review-feedback-from-Darin-for-262531main
branch
from
879f609
to
53472ba
Compare
|
Committed 262548@main (53472ba): https://commits.webkit.org/262548@main Reviewed commits have been landed. Closing PR #12346 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
53472ba
879f609
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-ios🧪 gtk-wk2🧪 api-gtk🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch