Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreviewed attempt to fix Catalyst build after 262488@main #12356

Merged
merged 1 commit into from Apr 4, 2023
Merged

Unreviewed attempt to fix Catalyst build after 262488@main #12356

merged 1 commit into from Apr 4, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 4, 2023 •
edited by webkit-early-warning-system

@cdumez cdumez self-assigned this Apr 4, 2023
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Apr 4, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 04fe9a9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 api-ios   🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 tv   🧪 mac-wk2   🧪 api-gtk
  🛠 tv-sim   🧪 mac-AS-debug-wk2
  🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 4, 2023
@cdumez
Unreviewed attempt to fix Catalyst build after 262488@main
4a71908 
https://bugs.webkit.org/show_bug.cgi?id=254964
rdar://107591818

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::updatePlayingMediaDidChange):

Canonical link: https://commits.webkit.org/262560@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Unreviewed-attempt-to-fix-Catalyst-build-after-262488main branch from 04fe9a9 to 4a71908 Compare April 4, 2023 03:36
@webkit-commit-queue
Copy link
Collaborator

Committed 262560@main (4a71908): https://commits.webkit.org/262560@main

Reviewed commits have been landed. Closing PR #12356 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4a71908 into WebKit:main Apr 4, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cdumez cdumez

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
3 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue