Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION(262547@main) ASSERTION FAILED: !m_size.isEmpty() #12406

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Apr 5, 2023

533f864

REGRESSION(262547@main) ASSERTION FAILED: !m_size.isEmpty()
https://bugs.webkit.org/show_bug.cgi?id=255025

Reviewed by NOBODY (OOPS!).

We sometimes need to create an instance of `ShareableBitmapConfiguration`
with an empty size. For example, when we send a
`ShareableBitmapConfiguration` object in its initial state over IPC.

* Source/WebKit/Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmapConfiguration::ShareableBitmapConfiguration):

533f864

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style ❌ πŸ›  ios ❌ πŸ›  mac ❌ πŸ›  wpe ❌ πŸ›  wincairo
❌ πŸ›  ios-sim ❌ πŸ›  mac-AS-debug ❌ πŸ§ͺ wpe-wk2
❌ πŸ§ͺ webkitperl ❌ πŸ§ͺ ios-wk2 ❌ πŸ§ͺ api-mac ❌ πŸ›  gtk
❌ πŸ§ͺ api-ios ❌ πŸ§ͺ mac-wk1 ❌ πŸ§ͺ gtk-wk2
❌ πŸ›  tv ❌ πŸ§ͺ mac-wk2 ❌ πŸ§ͺ api-gtk
❌ πŸ›  tv-sim ❌ πŸ§ͺ mac-AS-debug-wk2
❌ πŸ›  watch ❌ πŸ§ͺ mac-wk2-stress
❌ πŸ›  watch-sim

https://bugs.webkit.org/show_bug.cgi?id=255025

Reviewed by NOBODY (OOPS!).

We sometimes need to create an instance of `ShareableBitmapConfiguration`
with an empty size. For example, when we send a
`ShareableBitmapConfiguration` object in its initial state over IPC.

* Source/WebKit/Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmapConfiguration::ShareableBitmapConfiguration):
@obyknovenius obyknovenius self-assigned this Apr 5, 2023
@obyknovenius obyknovenius added the Layout and Rendering For bugs with layout and rendering of Web pages. label Apr 5, 2023
@obyknovenius obyknovenius deleted the fix/shareable-bitmap-configuration/empty-size branch April 5, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
2 participants