Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure isLatin1() is a no-op for LChar characters #12413

Merged
merged 1 commit into from Apr 5, 2023
Merged

Make sure isLatin1() is a no-op for LChar characters #12413

merged 1 commit into from Apr 5, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 5, 2023 •
edited by webkit-early-warning-system

b15ce8a

Make sure isLatin1() is a no-op for LChar characters
https://bugs.webkit.org/show_bug.cgi?id=255040
rdar://107666559

Reviewed by Mark Lam.

* Source/WTF/wtf/text/StringCommon.h:
(WTF::isLatin1):

Canonical link: https://commits.webkit.org/262627@main

b41234b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🧪 jsc-mips-tests

@cdumez cdumez self-assigned this Apr 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash b41234b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch-sim ✅ 🛠 jsc-mips
✅ 🧪 jsc-mips-tests

MenloDorian
MenloDorian approved these changes Apr 5, 2023
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Apr 5, 2023
@cdumez
Make sure isLatin1() is a no-op for LChar characters
b15ce8a 
https://bugs.webkit.org/show_bug.cgi?id=255040
rdar://107666559

Reviewed by Mark Lam.

* Source/WTF/wtf/text/StringCommon.h:
(WTF::isLatin1):

Canonical link: https://commits.webkit.org/262627@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Make-sure-isLatin1-is-a-no-op-for-LChar-characters branch from b41234b to b15ce8a Compare April 5, 2023 18:56
@webkit-commit-queue
Copy link
Collaborator

Committed 262627@main (b15ce8a): https://commits.webkit.org/262627@main

Reviewed commits have been landed. Closing PR #12413 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b15ce8a into WebKit:main Apr 5, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

@darinadler darinadler Awaiting requested review from darinadler

Assignees

@cdumez cdumez

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @MenloDorian