REGRESSION (macOS 13.3): Holding down-arrow beeps while scrolling before reaching end of document in WKWebView #12447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-codes
added
the
Scrolling
rr-codes
requested review from
smfr,
hortont424,
whsieh,
pxlcoder and
megangardner
|
EWS run on previous version of this PR (hash f729814) |
webkit-ews-buildbot
added
the
merging-blocked
pxlcoder
reviewed
Apr 6, 2023
rr-codes
removed
the
merging-blocked
|
EWS run on previous version of this PR (hash 4240023) |
pxlcoder
reviewed
Apr 7, 2023
|
EWS run on previous version of this PR (hash 46aa9a7) |
pxlcoder
approved these changes
Apr 7, 2023
|
EWS run on current version of this PR (hash 2a9f25b) |
…ore reaching end of document in WKWebView https://bugs.webkit.org/show_bug.cgi?id=255039 rdar://107667589 Reviewed by Aditya Keerthi. This was happening because the keyboard event is considered "unhandled" if the triggering key is already held down. This PR fixes this by simply correcting this behavior, since these events should actually be considered "handled". * Source/WebCore/platform/KeyboardScrollingAnimator.cpp: (WebCore::KeyboardScrollingAnimator::beginKeyboardScrollGesture): * Tools/TestWebKitAPI/Tests/mac/KeyboardEventTests.mm: (-[NSViewWithKeyDownOverride keyDown:]): (TestWebKitAPI::arrowKeyDownWithKeyRepeat): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/262743@main
webkit-commit-queue
force-pushed
the
eng/107667589
branch
from
2a9f25b
to
77d05a5
Compare
|
Committed 262743@main (77d05a5): https://commits.webkit.org/262743@main Reviewed commits have been landed. Closing PR #12447 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
77d05a5
2a9f25b
🛠 wpe🧪 wpe-wk2🧪 ios-wk2-wpt