Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions #1246

Merged
merged 0 commits into from Jun 2, 2022
Merged

Inline addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions #1246

merged 0 commits into from Jun 2, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 2, 2022 •
edited by webkit-early-warning-system

e0765bf

Inline addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions
https://bugs.webkit.org/show_bug.cgi?id=241230

Reviewed by Geoffrey Garen.

Inline addWebCoreOpaqueRoot() / containsWebCoreOpaqueRoot() functions since I
noticed looking at profiles that they weren't getting inlined. This is a ~0.35%
progression on Intel (neutral on Apple Silicon).

* Source/WebCore/bindings/js/WebCoreOpaqueRoot.h:
(WebCore::addWebCoreOpaqueRoot):
(WebCore::containsWebCoreOpaqueRoot):

Canonical link: https://commits.webkit.org/251229@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@cdumez cdumez self-assigned this Jun 2, 2022
@cdumez cdumez added Bindings For bugs related to the DOM bindings WebKit Nightly Build labels Jun 2, 2022
@cdumez cdumez requested a review from geoffreygaren June 2, 2022 17:32
geoffreygaren
geoffreygaren approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 2, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit e0765bf into WebKit:main Jun 2, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295138 (251229@main): https://commits.webkit.org/251229@main

Reviewed commits have been landed. Closing PR #1246 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 2, 2022
@cdumez cdumez deleted the 241230_inline_addWebCoreOpaqueRoot branch June 2, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

Assignees

@cdumez cdumez

Labels
Bindings For bugs related to the DOM bindings
Projects
None yet
Milestone
No milestone
3 participants
@cdumez @webkit-early-warning-system @geoffreygaren