Regression(259658@main) Geolocation permission prompt is no longer showing in modal view #12489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
force-pushed
the
255133_geolocation_prompt_fix
branch
from
e7d960f
to
891735d
Compare
|
EWS run on current version of this PR (hash 891735d)
|
|
EWS run on previous version of this PR (hash e7d960f)
|
hortont424
approved these changes
Apr 7, 2023
| @@ -196,7 +196,7 @@ - (void)_executeNextChallenge | |||
| [alert addAction:denyAction]; | |||
| [alert addAction:allowAction]; | |||
|
|
|||
| [[_activeChallenge->view window].rootViewController presentViewController:alert animated:YES completion:nil]; | |||
| [[UIViewController _viewControllerForFullScreenPresentationFromView:_activeChallenge->view.get()] presentViewController:alert animated:YES completion:nil]; | |||
There was a problem hiding this comment.
This is what we do throughout WK2 so 👍
whsieh
approved these changes
Apr 7, 2023
…owing in modal view https://bugs.webkit.org/show_bug.cgi?id=255133 rdar://107352115 Reviewed by Wenson Hsieh and Tim Horton. Use the same view controller to present the prompt as the UIWebView code used to. I have verified locally that this fixes the issue. * Source/WebKit/UIProcess/ios/WKWebGeolocationPolicyDeciderIOS.mm: (-[WKWebGeolocationPolicyDecider _executeNextChallenge]): Canonical link: https://commits.webkit.org/262697@main
webkit-commit-queue
force-pushed
the
255133_geolocation_prompt_fix
branch
from
891735d
to
14f4676
Compare
|
Committed 262697@main (14f4676): https://commits.webkit.org/262697@main Reviewed commits have been landed. Closing PR #12489 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
14f4676
891735d
🛠 ios🛠 wincairo🛠 ios-sim🧪 wpe-wk2🧪 ios-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2