Use $isSIMDPlatform for wasm SIMD test; re-enable no longer failing tests on ARMv7 #12504

eugeneia · 2023-04-07T12:48:35Z

`3096b28`

Use $isSIMDPlatform for wasm SIMD test; re-enable no longer failing tests on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=255148

Unreviewed gardening.

Prefer using the existing var over lists of supported architectures.

Also re-enable two tests which appear not to have really needed SIMD support to
pass, and two other tests that are no longer failing on ARMv7.

* JSTests/stress/shared-wasm-memory-with-zero-byte.js: Re-enabled on armv7
* JSTests/wasm/references/memory_copy_shared.js: Re-enabled on armv7
* JSTests/wasm/references/memory_fill_shared.js: Re-enabled on armv7
* JSTests/wasm/stress/simd-global.js:
* JSTests/wasm/stress/tuple-and-simd.js:
* JSTests/wasm/v8/exceptions-simd.js:
* JSTests/wasm/v8/regress/regress-10309.js:
* JSTests/wasm/v8/regress/regress-1045225.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1045737.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1048241.js:
* JSTests/wasm/v8/regress/regress-1054466.js:
* JSTests/wasm/v8/regress/regress-1065599.js:
* JSTests/wasm/v8/regress/regress-1070078.js:
* JSTests/wasm/v8/regress/regress-1074586.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1080902.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1081030.js:
* JSTests/wasm/v8/regress/regress-10831.js:
* JSTests/wasm/v8/regress/regress-10898.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1111522.js:
* JSTests/wasm/v8/regress/regress-1112124.js:
* JSTests/wasm/v8/regress/regress-1116019.js:
* JSTests/wasm/v8/regress/regress-1124885.js:
* JSTests/wasm/v8/regress/regress-1132461.js:
* JSTests/wasm/v8/regress/regress-1140549.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1153442.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1161555.js:
* JSTests/wasm/v8/regress/regress-1161654.js:
* JSTests/wasm/v8/regress/regress-1161954.js:
* JSTests/wasm/v8/regress/regress-1165966.js:
* JSTests/wasm/v8/regress/regress-1179025.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1179182.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1187831.js:
* JSTests/wasm/v8/regress/regress-1199662.js:
* JSTests/wasm/v8/regress/regress-1220855.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1231950.js:
* JSTests/wasm/v8/regress/regress-1242300.js:
* JSTests/wasm/v8/regress/regress-1242689.js:
* JSTests/wasm/v8/regress/regress-1264462.js:
* JSTests/wasm/v8/regress/regress-1271244.js:
* JSTests/wasm/v8/regress/regress-1271456.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-1271538.js:
* JSTests/wasm/v8/regress/regress-1282224.js:
* JSTests/wasm/v8/regress/regress-1283042.js:
* JSTests/wasm/v8/regress/regress-1283395.js:
* JSTests/wasm/v8/regress/regress-1284980.js:
* JSTests/wasm/v8/regress/regress-1286253.js:
* JSTests/wasm/v8/regress/regress-1289678.js:
* JSTests/wasm/v8/regress/regress-1290079.js:
* JSTests/wasm/v8/regress/regress-9425.js: Re-enabled on armv7
* JSTests/wasm/v8/regress/regress-9447.js:
* JSTests/wasm/v8/regress/regress-crbug-1338980.js:
* JSTests/wasm/v8/regress/regress-crbug-1355070.js:
* JSTests/wasm/v8/regress/regress-crbug-1356718.js:

Canonical link: https://commits.webkit.org/262716@main

2c9f5ce

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 api-ios	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🧪 mac-wk2	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-04-07T12:48:47Z

EWS run on previous version of this PR (hash e136e7b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 api-ios	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🧪 mac-wk2	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-04-07T15:13:22Z

EWS run on current version of this PR (hash 2c9f5ce)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 api-ios	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🧪 mac-wk2	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

AtariDreams · 2023-04-07T16:40:26Z

This is stuck now.

guijemont · 2023-04-07T17:19:53Z

Removing merging-blocked as this was due to broken bots

…ests on ARMv7 https://bugs.webkit.org/show_bug.cgi?id=255148 Unreviewed gardening. Prefer using the existing var over lists of supported architectures. Also re-enable two tests which appear not to have really needed SIMD support to pass, and two other tests that are no longer failing on ARMv7. * JSTests/stress/shared-wasm-memory-with-zero-byte.js: Re-enabled on armv7 * JSTests/wasm/references/memory_copy_shared.js: Re-enabled on armv7 * JSTests/wasm/references/memory_fill_shared.js: Re-enabled on armv7 * JSTests/wasm/stress/simd-global.js: * JSTests/wasm/stress/tuple-and-simd.js: * JSTests/wasm/v8/exceptions-simd.js: * JSTests/wasm/v8/regress/regress-10309.js: * JSTests/wasm/v8/regress/regress-1045225.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1045737.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1048241.js: * JSTests/wasm/v8/regress/regress-1054466.js: * JSTests/wasm/v8/regress/regress-1065599.js: * JSTests/wasm/v8/regress/regress-1070078.js: * JSTests/wasm/v8/regress/regress-1074586.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1080902.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1081030.js: * JSTests/wasm/v8/regress/regress-10831.js: * JSTests/wasm/v8/regress/regress-10898.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1111522.js: * JSTests/wasm/v8/regress/regress-1112124.js: * JSTests/wasm/v8/regress/regress-1116019.js: * JSTests/wasm/v8/regress/regress-1124885.js: * JSTests/wasm/v8/regress/regress-1132461.js: * JSTests/wasm/v8/regress/regress-1140549.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1153442.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1161555.js: * JSTests/wasm/v8/regress/regress-1161654.js: * JSTests/wasm/v8/regress/regress-1161954.js: * JSTests/wasm/v8/regress/regress-1165966.js: * JSTests/wasm/v8/regress/regress-1179025.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1179182.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1187831.js: * JSTests/wasm/v8/regress/regress-1199662.js: * JSTests/wasm/v8/regress/regress-1220855.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1231950.js: * JSTests/wasm/v8/regress/regress-1242300.js: * JSTests/wasm/v8/regress/regress-1242689.js: * JSTests/wasm/v8/regress/regress-1264462.js: * JSTests/wasm/v8/regress/regress-1271244.js: * JSTests/wasm/v8/regress/regress-1271456.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-1271538.js: * JSTests/wasm/v8/regress/regress-1282224.js: * JSTests/wasm/v8/regress/regress-1283042.js: * JSTests/wasm/v8/regress/regress-1283395.js: * JSTests/wasm/v8/regress/regress-1284980.js: * JSTests/wasm/v8/regress/regress-1286253.js: * JSTests/wasm/v8/regress/regress-1289678.js: * JSTests/wasm/v8/regress/regress-1290079.js: * JSTests/wasm/v8/regress/regress-9425.js: Re-enabled on armv7 * JSTests/wasm/v8/regress/regress-9447.js: * JSTests/wasm/v8/regress/regress-crbug-1338980.js: * JSTests/wasm/v8/regress/regress-crbug-1355070.js: * JSTests/wasm/v8/regress/regress-crbug-1356718.js: Canonical link: https://commits.webkit.org/262716@main

webkit-commit-queue · 2023-04-07T17:54:26Z

Committed 262716@main (3096b28): https://commits.webkit.org/262716@main

Reviewed commits have been landed. Closing PR #12504 and removing active labels.

eugeneia requested a review from a team as a code owner April 7, 2023 12:48

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 7, 2023

eugeneia force-pushed the max-skipathon-04-2023-squash branch from e136e7b to 2c9f5ce Compare April 7, 2023 15:08

guijemont added merge-queue Applied to send a pull request to merge-queue JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases labels Apr 7, 2023

webkit-ews-buildbot removed the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2023

guijemont added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Apr 7, 2023

webkit-commit-queue force-pushed the max-skipathon-04-2023-squash branch from 2c9f5ce to 3096b28 Compare April 7, 2023 17:54

webkit-commit-queue merged commit 3096b28 into WebKit:main Apr 7, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use $isSIMDPlatform for wasm SIMD test; re-enable no longer failing tests on ARMv7 #12504

Use $isSIMDPlatform for wasm SIMD test; re-enable no longer failing tests on ARMv7 #12504

eugeneia commented Apr 7, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Apr 7, 2023 •

edited

webkit-early-warning-system commented Apr 7, 2023 •

edited

AtariDreams commented Apr 7, 2023

guijemont commented Apr 7, 2023

webkit-commit-queue commented Apr 7, 2023

Use $isSIMDPlatform for wasm SIMD test; re-enable no longer failing tests on ARMv7 #12504

Use $isSIMDPlatform for wasm SIMD test; re-enable no longer failing tests on ARMv7 #12504

Conversation

eugeneia commented Apr 7, 2023 • edited by webkit-early-warning-system

3096b28

webkit-early-warning-system commented Apr 7, 2023 • edited

webkit-early-warning-system commented Apr 7, 2023 • edited

AtariDreams commented Apr 7, 2023

guijemont commented Apr 7, 2023

webkit-commit-queue commented Apr 7, 2023

eugeneia commented Apr 7, 2023 •

edited by webkit-early-warning-system

`3096b28`

webkit-early-warning-system commented Apr 7, 2023 •

edited

webkit-early-warning-system commented Apr 7, 2023 •

edited