[ews-build] Split iOS layout test queue into no-WPT / only-WPT configurations #12508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhaddad
added
the
Tools / Tests
|
EWS run on previous version of this PR (hash 60c70c4) |
ryanhaddad
force-pushed
the
eng/ews-build-Split-iOS-layout-test-queue-into-no-WPT--only-WPT-configurations
branch
from
60c70c4
to
31ff2dd
Compare
|
The thing I'm concerned about is the conditional |
|
EWS run on previous version of this PR (hash 31ff2dd) |
JonWBedard
approved these changes
Apr 7, 2023
ryanhaddad
force-pushed
the
eng/ews-build-Split-iOS-layout-test-queue-into-no-WPT--only-WPT-configurations
branch
from
31ff2dd
to
b6c9262
Compare
|
EWS run on previous version of this PR (hash b6c9262)
|
ryanhaddad
force-pushed
the
eng/ews-build-Split-iOS-layout-test-queue-into-no-WPT--only-WPT-configurations
branch
from
b6c9262
to
0a8e61b
Compare
Added logic to remove these arguments for this step. |
|
EWS run on current version of this PR (hash 0a8e61b)
|
ryanhaddad
added
skip-ews
…urations https://bugs.webkit.org/show_bug.cgi?id=254559 rdar://107291888 Reviewed by Jonathan Bedard. The first iteration of this commit used new steps and factories to accomplish the no-WPT / only-WPT split, but if retries were required to determine if a failure was pre-existing the bots ended up running the whole suite. Using the additional arguments approach instead will make sure the no-WPT / only-WPT queues behave as expected even in the retry case. These specific additional arguments will be removed in the RunWebKitTestsInStressMode so they don't interfere with the intent of this step running only the new or modified tests. * Tools/CISupport/ews-build/config.json: * Tools/CISupport/ews-build/factories.py: (iOSTestsFactory): (iOSTestsNoWPTFactory): Deleted. (iOSTestsOnlyWPTFactory): Deleted. * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): * Tools/CISupport/ews-build/loadConfig.py: * Tools/CISupport/ews-build/steps.py: (RunWebKitTestsInStressMode): (RunWebKitTestsNoWPT): Deleted. (RunWebKitTestsNoWPT.setLayoutTestCommand): Deleted. (RunWebKitTestsOnlyWPT): Deleted. (RunWebKitTestsOnlyWPT.setLayoutTestCommand): Deleted. * Tools/CISupport/ews-build/steps_unittest.py: (TestRunWebKitTestsInStressMode.test_success_additional_arguments): Add new unit test. (TestRunWebKitTestsNoWPT): Deleted. (TestRunWebKitTestsNoWPT.setUp): Deleted. (TestRunWebKitTestsNoWPT.tearDown): Deleted. (TestRunWebKitTestsNoWPT.configureStep): Deleted. (TestRunWebKitTestsNoWPT.test_success): Deleted. (TestRunWebKitTestsOnlyWPT): Deleted. (TestRunWebKitTestsOnlyWPT.setUp): Deleted. (TestRunWebKitTestsOnlyWPT.tearDown): Deleted. (TestRunWebKitTestsOnlyWPT.configureStep): Deleted. (TestRunWebKitTestsOnlyWPT.test_success): Deleted. Canonical link: https://commits.webkit.org/262714@main
webkit-commit-queue
force-pushed
the
eng/ews-build-Split-iOS-layout-test-queue-into-no-WPT--only-WPT-configurations
branch
from
0a8e61b
to
3b1f649
Compare
|
Committed 262714@main (3b1f649): https://commits.webkit.org/262714@main Reviewed commits have been landed. Closing PR #12508 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3b1f649
0a8e61b
🛠 ios🛠 wpe🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 tv-sim🧪 mac-wk2-stress🛠 watch-sim