Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better attachment save icon svg, with correct colors #12517

Merged
merged 1 commit into from Apr 9, 2023
Merged

Better attachment save icon svg, with correct colors #12517

merged 1 commit into from Apr 9, 2023

Conversation

squelart
Copy link
Contributor

@squelart squelart commented Apr 7, 2023 •
edited by webkit-early-warning-system

3a0a1eb

Better attachment save icon svg, with correct colors
https://bugs.webkit.org/show_bug.cgi?id=255161
rdar://107157484

Reviewed by Aditya Keerthi.

Use a better SVG for the attachment icon, and ensure that both `stroke` and `fill` have the correct color.
Also use the correct color for the surrounding circle on macOS.

* Source/WebCore/html/shadow/attachmentElementShadow.css:
(button#attachment-save-button):
(div#attachment-save-icon):

Canonical link: https://commits.webkit.org/262759@main

4d116c0

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 api-ios ✅ 🧪 api-gtk
✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@squelart squelart self-assigned this Apr 7, 2023
@squelart squelart added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Apr 7, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 5d82d3f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🛠 gtk
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 api-ios   🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64   🧪 mac-wk2 ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@squelart squelart force-pushed the eng/attachment-improve-save-button-icon branch from 5d82d3f to b3b5c01 Compare April 7, 2023 18:01
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash b3b5c01)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ✅ 🛠 tv   🧪 api-ios   🧪 api-gtk
  🧪 mac-wk2   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@squelart squelart force-pushed the eng/attachment-improve-save-button-icon branch from b3b5c01 to 644c0d1 Compare April 7, 2023 18:37
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 644c0d1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 api-ios ✅ 🧪 api-gtk
✅ 🧪 mac-wk2   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 7, 2023
@squelart squelart added the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2023
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Apr 7, 2023
@squelart squelart removed the merge-queue Applied to send a pull request to merge-queue label Apr 7, 2023
@squelart squelart force-pushed the eng/attachment-improve-save-button-icon branch from 644c0d1 to 4d116c0 Compare April 7, 2023 22:31
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4d116c0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 api-ios ✅ 🧪 api-gtk
✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@squelart squelart added the merge-queue Applied to send a pull request to merge-queue label Apr 9, 2023
@squelart
Better attachment save icon svg, with correct colors
3a0a1eb 
https://bugs.webkit.org/show_bug.cgi?id=255161
rdar://107157484

Reviewed by Aditya Keerthi.

Use a better SVG for the attachment icon, and ensure that both `stroke` and `fill` have the correct color.
Also use the correct color for the surrounding circle on macOS.

* Source/WebCore/html/shadow/attachmentElementShadow.css:
(button#attachment-save-button):
(div#attachment-save-icon):

Canonical link: https://commits.webkit.org/262759@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/attachment-improve-save-button-icon branch from 4d116c0 to 3a0a1eb Compare April 9, 2023 22:40
@webkit-commit-queue
Copy link
Collaborator

Committed 262759@main (3a0a1eb): https://commits.webkit.org/262759@main

Reviewed commits have been landed. Closing PR #12517 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 3a0a1eb into WebKit:main Apr 9, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxlcoder pxlcoder pxlcoder approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

Assignees

@squelart squelart

Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
Milestone
No milestone
6 participants
@squelart @webkit-early-warning-system @webkit-commit-queue @pxlcoder @Ahmad-S792 @webkit-ews-buildbot