Vimeo video goes black if you hit the in-website play button while the video is open in PiP #12520
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvollan
added
the
WebKit Misc.
pvollan
force-pushed
the
eng/Vimeo-video-goes-black-if-you-hit-the-in-website-play-button-while-the-video-is-open-in-PiP
branch
from
b193cf2
to
6d4718b
Compare
|
EWS run on current version of this PR (hash 6d4718b)
|
|
EWS run on previous version of this PR (hash b193cf2) |
smfr
approved these changes
Apr 7, 2023
|
Thanks for reviewing, Simon! |
pvollan
added
merge-queue
Thanks for reviewing, Geoff :) |
…e video is open in PiP https://bugs.webkit.org/show_bug.cgi?id=255163 rdar://107592139 Reviewed by Simon Fraser. Vimeo enters fullscreen when starting playback from the inline play button while already in PIP. This behavior is revealing a bug in the fullscreen handling. This patch introduces a quirk to work around this issue. This patch also reverts <https://commits.webkit.org/262703@main> since it did not resolve the issue. * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::blocksEnteringStandardFullscreenFromPictureInPictureQuirk const): * Source/WebCore/page/Quirks.h: * Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm: (VideoFullscreenInterfaceAVKit::didStopPictureInPicture): (VideoFullscreenInterfaceAVKit::prepareForPictureInPictureStopWithCompletionHandler): * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): * Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h: (WebKit::VideoFullscreenManager::videoElementInPictureInPicture const): Canonical link: https://commits.webkit.org/262723@main
webkit-commit-queue
force-pushed
the
eng/Vimeo-video-goes-black-if-you-hit-the-in-website-play-button-while-the-video-is-open-in-PiP
branch
from
6d4718b
to
12441d9
Compare
|
Committed 262723@main (12441d9): https://commits.webkit.org/262723@main Reviewed commits have been landed. Closing PR #12520 and removing active labels. |
webkit-commit-queue
removed
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12441d9
6d4718b
🛠 mac🛠 wpe🛠 wincairo🧪 bindings🛠 mac-AS-debug🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🛠 gtk🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 tv-sim🧪 mac-wk2-stress🛠 🧪 merge🛠 watch-sim