Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Legacy Dashboard Support #12554

Merged
merged 1 commit into from Apr 11, 2023
Merged

Remove Legacy Dashboard Support #12554

merged 1 commit into from Apr 11, 2023

Conversation

AtariDreams
Copy link
Contributor

@AtariDreams AtariDreams commented Apr 9, 2023 •
edited by webkit-early-warning-system

e432547

Remove Legacy Dashboard Support
https://bugs.webkit.org/show_bug.cgi?id=255204

Reviewed by Alexey Proskuryakov.

The Legacy Dashboard itself has not been used for many years.
We can remove it without issue now, especially since nothing
is dependent on the files themselves anymore.

* Source/WebCore/platform/mac/PasteboardMac.mm:
  (WebCore::Pasteboard::setDragImage):
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/MigratedHeaders-input.xcfilelist:
* Source/WebKit/MigratedHeaders-output.xcfilelist:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKitLegacy/PlatformMac.cmake:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
* Source/WebKitLegacy/mac/WebKit.order:
* Source/WebKitLegacy/mac/WebView/WebDashboardRegion.h: Removed.
* Source/WebKitLegacy/mac/WebView/WebDashboardRegion.mm: Removed.
* Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
  (-[WebView _addScrollerDashboardRegions:]): Deleted.
  (-[WebView _dashboardRegions]): Deleted.
  (-[WebView _setDashboardBehavior:to:]): Deleted.
  (-[WebView _dashboardBehavior:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebViewData.h:
* Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:

Canonical link: https://commits.webkit.org/262798@main

9868bb9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 api-ios ❌ 🧪 api-gtk
✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 4a59794)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 api-ios ✅ 🧪 api-gtk
✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Apr 10, 2023
@AtariDreams AtariDreams changed the title Remove Dashboard Support Remove Legacy Dashboard Support Apr 10, 2023
@AtariDreams AtariDreams force-pushed the eng/Dashboard-code-can-be-removed branch from 4a59794 to 9868bb9 Compare April 10, 2023 22:13
@AtariDreams
Copy link
Contributor Author

@cdumez Do you think this is acceptable?

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9868bb9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 tv ✅ 🧪 api-ios ❌ 🧪 api-gtk
✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 10, 2023
aproskuryakov
aproskuryakov approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@aproskuryakov aproskuryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gtk failures look unrelated.

@aproskuryakov aproskuryakov added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Apr 11, 2023
@AtariDreams @aproskuryakov
Remove Legacy Dashboard Support
e432547 
https://bugs.webkit.org/show_bug.cgi?id=255204

Reviewed by Alexey Proskuryakov.

The Legacy Dashboard itself has not been used for many years.
We can remove it without issue now, especially since nothing
is dependent on the files themselves anymore.

* Source/WebCore/platform/mac/PasteboardMac.mm:
  (WebCore::Pasteboard::setDragImage):
* Source/WebKit/Configurations/WebKit.xcconfig:
* Source/WebKit/MigratedHeaders-input.xcfilelist:
* Source/WebKit/MigratedHeaders-output.xcfilelist:
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKitLegacy/PlatformMac.cmake:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:
* Source/WebKitLegacy/mac/WebKit.order:
* Source/WebKitLegacy/mac/WebView/WebDashboardRegion.h: Removed.
* Source/WebKitLegacy/mac/WebView/WebDashboardRegion.mm: Removed.
* Source/WebKitLegacy/mac/WebView/WebUIDelegatePrivate.h:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
  (-[WebView _addScrollerDashboardRegions:]): Deleted.
  (-[WebView _dashboardRegions]): Deleted.
  (-[WebView _setDashboardBehavior:to:]): Deleted.
  (-[WebView _dashboardBehavior:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebViewData.h:
* Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:

Canonical link: https://commits.webkit.org/262798@main
@webkit-commit-queue
Copy link
Collaborator

Committed 262798@main (e432547): https://commits.webkit.org/262798@main

Reviewed commits have been landed. Closing PR #12554 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e432547 into WebKit:main Apr 11, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 11, 2023
@AtariDreams AtariDreams deleted the eng/Dashboard-code-can-be-removed branch April 11, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

Assignees

@AtariDreams AtariDreams

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
6 participants
@AtariDreams @webkit-early-warning-system @webkit-commit-queue @aproskuryakov @Ahmad-S792 @webkit-ews-buildbot