Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PlayStation] Avoid mincore() call in BlockDirectory::updatePercentageOfPagedOutPages() #12562

Merged
merged 1 commit into from Apr 10, 2023
Merged

[PlayStation] Avoid mincore() call in BlockDirectory::updatePercentageOfPagedOutPages() #12562

merged 1 commit into from Apr 10, 2023

Conversation

unicodon
Copy link
Contributor

@unicodon unicodon commented Apr 10, 2023 •
edited by webkit-early-warning-system

7fab056

[PlayStation] Avoid mincore() call in BlockDirectory::updatePercentageOfPagedOutPages()
https://bugs.webkit.org/show_bug.cgi?id=255202

Reviewed by Ross Kirsling.

Until we figure out the best way on PlayStation to check if pages are paged out, disable
the code block of BlockDirectory::updatePercentageOfPagedOutPages() in the PlayStation port.

* Source/JavaScriptCore/heap/BlockDirectory.cpp:
(JSC::BlockDirectory::updatePercentageOfPagedOutPages):

Canonical link: https://commits.webkit.org/262766@main

03e7ec6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 api-ios ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@unicodon unicodon requested a review from a team as a code owner April 10, 2023 05:37
@unicodon unicodon self-assigned this Apr 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash db6ab65)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 api-ios ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@unicodon unicodon added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Apr 10, 2023
rkirsling
rkirsling reviewed Apr 10, 2023
View reviewed changes
Source/JavaScriptCore/heap/BlockDirectory.cpp Outdated
Comment on lines 62 to 64
#if OS(WINDOWS) || PLATFORM(PLAYSTATION)
// FIXME: We should figure out a solution for Windows and PlayStation.
#elif OS(UNIX)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we may want a common solution for Win & PS, I think it's probably best to just use #if OS(UNIX) && !PLATFORM(PLAYSTATION)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably Win's solution will be different from PS's so I'll change that condition.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 10, 2023
@unicodon unicodon force-pushed the eng/PlayStation-Avoid-mincore-call-in-BlockDirectoryupdatePercentageOfPagedOutPages branch from db6ab65 to 03e7ec6 Compare April 10, 2023 07:37
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 03e7ec6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🛠 tv ✅ 🧪 api-ios ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🧪 mac-wk2 ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

rkirsling
rkirsling approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@unicodon unicodon added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Apr 10, 2023
@unicodon
[PlayStation] Avoid mincore() call in BlockDirectory::updatePercentag…
7fab056 
…eOfPagedOutPages()

https://bugs.webkit.org/show_bug.cgi?id=255202

Reviewed by Ross Kirsling.

Until we figure out the best way on PlayStation to check if pages are paged out, disable
the code block of BlockDirectory::updatePercentageOfPagedOutPages() in the PlayStation port.

* Source/JavaScriptCore/heap/BlockDirectory.cpp:
(JSC::BlockDirectory::updatePercentageOfPagedOutPages):

Canonical link: https://commits.webkit.org/262766@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/PlayStation-Avoid-mincore-call-in-BlockDirectoryupdatePercentageOfPagedOutPages branch from 03e7ec6 to 7fab056 Compare April 10, 2023 09:50
@webkit-commit-queue
Copy link
Collaborator

Committed 262766@main (7fab056): https://commits.webkit.org/262766@main

Reviewed commits have been landed. Closing PR #12562 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7fab056 into WebKit:main Apr 10, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 10, 2023
@unicodon unicodon deleted the eng/PlayStation-Avoid-mincore-call-in-BlockDirectoryupdatePercentageOfPagedOutPages branch April 10, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkirsling rkirsling rkirsling approved these changes

Assignees

@unicodon unicodon

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
5 participants
@unicodon @webkit-early-warning-system @webkit-commit-queue @rkirsling @webkit-ews-buildbot