Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(262563@main): [ iOS ] imported/w3c/web-platform-tests/editing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative.html is a constant text failure #12583

Merged
merged 1 commit into from Apr 10, 2023
Merged

REGRESSION(262563@main): [ iOS ] imported/w3c/web-platform-tests/editing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative.html is a constant text failure #12583

merged 1 commit into from Apr 10, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Apr 10, 2023 •
edited by webkit-early-warning-system

c3cf8c9

REGRESSION(262563@main): [ iOS ] imported/w3c/web-platform-tests/editing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=255182

Unreviewed test gardening. Check in the failing test expectation for now.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/editing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative-expected.txt: Added.

Canonical link: https://commits.webkit.org/262782@main

7f52472

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
❌ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🛠 tv   🧪 api-ios   🧪 api-gtk
  🧪 mac-wk2   🧪 mac-AS-debug-wk2
  🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@rniwa rniwa self-assigned this Apr 10, 2023
@rniwa rniwa added the HTML Editing For bugs in HTML editing support (including designMode and contentEditable). label Apr 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 13ed847)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🛠 tv   🧪 api-ios   🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64   🧪 mac-wk2   🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
✅ 🛠 watch
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 10, 2023
@webkit-commit-queue
Copy link
Collaborator

Commit message contains (OOPS!) and no reviewer found, blocking PR #12583

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Apr 10, 2023
@rniwa rniwa removed the merging-blocked Applied to prevent a change from being merged label Apr 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7f52472)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
❌ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🛠 tv   🧪 api-ios   🧪 api-gtk
  🧪 mac-wk2   🧪 mac-AS-debug-wk2
  🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 10, 2023
@rniwa
REGRESSION(262563@main): [ iOS ] imported/w3c/web-platform-tests/edit…
c3cf8c9 
…ing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative.html is a constant text failure

https://bugs.webkit.org/show_bug.cgi?id=255182

Unreviewed test gardening. Check in the failing test expectation for now.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/editing/other/editable-state-and-focus-in-shadow-dom-in-designMode.tentative-expected.txt: Added.

Canonical link: https://commits.webkit.org/262782@main
@webkit-commit-queue
Copy link
Collaborator

Test gardening commit 262782@main (c3cf8c9): https://commits.webkit.org/262782@main

Reviewed commits have been landed. Closing PR #12583 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c3cf8c9 into WebKit:main Apr 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 10, 2023
@rniwa rniwa deleted the fix255182 branch April 10, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rniwa rniwa

Labels
HTML Editing For bugs in HTML editing support (including designMode and contentEditable).
Projects
None yet
Milestone
No milestone
3 participants
@rniwa @webkit-early-warning-system @webkit-commit-queue