Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix availability version on JSRemoteInspector*InspectionFollowsInternalPolicies #12621

Merged
merged 1 commit into from Apr 11, 2023
Merged

Fix availability version on JSRemoteInspector*InspectionFollowsInternalPolicies #12621

merged 1 commit into from Apr 11, 2023

Conversation

emw-apple
Copy link
Contributor

@emw-apple emw-apple commented Apr 11, 2023 •
edited by webkit-early-warning-system

5638cd7

Fix availability version on JSRemoteInspector*InspectionFollowsInternalPolicies
https://bugs.webkit.org/show_bug.cgi?id=255299

Reviewed by Patrick Angle.

These SPI declarations have been available since macOS 13.3 / iOS 16.4,
but were not updated in https://commits.webkit.org/260895@main.

* Source/JavaScriptCore/API/JSRemoteInspector.h:

Canonical link: https://commits.webkit.org/262842@main

b0014fd

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@emw-apple emw-apple requested a review from a team as a code owner April 11, 2023 19:58
@emw-apple emw-apple self-assigned this Apr 11, 2023
@emw-apple emw-apple added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Apr 11, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash b0014fd)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@emw-apple emw-apple added the merge-queue Applied to send a pull request to merge-queue label Apr 11, 2023
@emw-apple
Fix availability version on JSRemoteInspector*InspectionFollowsIntern…
5638cd7 
…alPolicies

https://bugs.webkit.org/show_bug.cgi?id=255299

Reviewed by Patrick Angle.

These SPI declarations have been available since macOS 13.3 / iOS 16.4,
but were not updated in https://commits.webkit.org/260895@main.

* Source/JavaScriptCore/API/JSRemoteInspector.h:

Canonical link: https://commits.webkit.org/262842@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-availability-version-on-JSRemoteInspectorInspectionFollowsInternalPolicies branch from b0014fd to 5638cd7 Compare April 11, 2023 22:10
@webkit-commit-queue
Copy link
Collaborator

Committed 262842@main (5638cd7): https://commits.webkit.org/262842@main

Reviewed commits have been landed. Closing PR #12621 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5638cd7 into WebKit:main Apr 11, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickangle patrickangle patrickangle approved these changes

Assignees

@emw-apple emw-apple

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@emw-apple @webkit-early-warning-system @webkit-commit-queue @patrickangle