background-size should not accept unitless lengths #12644

annevk · 2023-04-12T07:21:19Z

`0b6c4aa`

background-size should not accept unitless lengths
https://bugs.webkit.org/show_bug.cgi?id=139029
rdar://97039770

Reviewed by Antti Koivisto and Tim Nguyen.

Align with other browsers by not using unitless length parsing for background-size.

* LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt:
* LayoutTests/fast/backgrounds/size/parsing-inherit-expected.txt:
* LayoutTests/fast/backgrounds/size/resources/parsing-background-size-values.js:
(test):
* LayoutTests/fast/backgrounds/size/resources/parsing-inherit.js:
(test):
* LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002-expected.txt:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::shouldAcceptUnitlessValue):
(WebCore::CSSPropertyParserHelpers::IntegerTypeRawKnownTokenTypeNumberConsumer::consume):
(WebCore::CSSPropertyParserHelpers::IntegerTypeKnownTokenTypeNumberConsumer::consume):
(WebCore::CSSPropertyParserHelpers::NumberRawKnownTokenTypeNumberConsumer::consume):
(WebCore::CSSPropertyParserHelpers::NumberCSSPrimitiveValueWithCalcWithKnownTokenTypeNumberConsumer::consume):
(WebCore::CSSPropertyParserHelpers::PercentCSSPrimitiveValueWithCalcWithKnownTokenTypePercentConsumer::consume):
(WebCore::CSSPropertyParserHelpers::consumeMetaConsumer):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeRGBParametersRaw):
(WebCore::CSSPropertyParserHelpers::consumeColorInterpolationMethod):
(WebCore::CSSPropertyParserHelpers::parseColorMixFunctionParametersRaw):
(WebCore::CSSPropertyParserHelpers::consumePositionCoordinates):
(WebCore::CSSPropertyParserHelpers::consumePrefixedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumePrefixedLinearGradient):
(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):
(WebCore::CSSPropertyParserHelpers::consumeConicGradient):
(WebCore::CSSPropertyParserHelpers::consumeSingleShadow):
(WebCore::CSSPropertyParserHelpers::consumeFamilyNameList):
(WebCore::CSSPropertyParserHelpers::consumeFontVariantEastAsian):
(WebCore::CSSPropertyParserHelpers::consumeFontVariantAlternates):
(WebCore::CSSPropertyParserHelpers::consumeClip):
(WebCore::CSSPropertyParserHelpers::consumeSteps):
(WebCore::CSSPropertyParserHelpers::consumeCubicBezier):
(WebCore::CSSPropertyParserHelpers::consumeSpringFunction):
(WebCore::CSSPropertyParserHelpers::consumeTransformFunction):
(WebCore::CSSPropertyParserHelpers::consumeAttr):
(WebCore::CSSPropertyParserHelpers::consumeBasicShapePath):
(WebCore::CSSPropertyParserHelpers::consumeReflect):
(WebCore::CSSPropertyParserHelpers::consumeBackgroundSize):
(WebCore::CSSPropertyParserHelpers::consumeAlignTracks):
(WebCore::CSSPropertyParserHelpers::consumeJustifyTracks):
(WebCore::CSSPropertyParserHelpers::consumeHangingPunctuation):

Canonical link: https://commits.webkit.org/262873@main

5e1b997

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-12T07:29:50Z

EWS run on previous version of this PR (hash a7be029)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

annevk · 2023-04-12T15:52:59Z

All I changed is the commit message based on some feedback from smfr. This should be good to go.

webkit-early-warning-system · 2023-04-12T15:57:52Z

Starting EWS tests for 5e1b997. Live statuses available at the PR page, #12644

webkit-early-warning-system · 2023-04-12T15:57:53Z

EWS run on current version of this PR (hash 5e1b997)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

nt1m

This affects -webkit-background-size too, which seems undesirable?

nt1m

This is probably fine since this only affects quirks mode.

https://bugs.webkit.org/show_bug.cgi?id=139029 rdar://97039770 Reviewed by Antti Koivisto and Tim Nguyen. Align with other browsers by not using unitless length parsing for background-size. * LayoutTests/fast/backgrounds/size/parsing-background-size-values-expected.txt: * LayoutTests/fast/backgrounds/size/parsing-inherit-expected.txt: * LayoutTests/fast/backgrounds/size/resources/parsing-background-size-values.js: (test): * LayoutTests/fast/backgrounds/size/resources/parsing-inherit.js: (test): * LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-002-expected.txt: * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::shouldAcceptUnitlessValue): (WebCore::CSSPropertyParserHelpers::IntegerTypeRawKnownTokenTypeNumberConsumer::consume): (WebCore::CSSPropertyParserHelpers::IntegerTypeKnownTokenTypeNumberConsumer::consume): (WebCore::CSSPropertyParserHelpers::NumberRawKnownTokenTypeNumberConsumer::consume): (WebCore::CSSPropertyParserHelpers::NumberCSSPrimitiveValueWithCalcWithKnownTokenTypeNumberConsumer::consume): (WebCore::CSSPropertyParserHelpers::PercentCSSPrimitiveValueWithCalcWithKnownTokenTypePercentConsumer::consume): (WebCore::CSSPropertyParserHelpers::consumeMetaConsumer): (WebCore::CSSPropertyParserHelpers::parseNonRelativeRGBParametersRaw): (WebCore::CSSPropertyParserHelpers::consumeColorInterpolationMethod): (WebCore::CSSPropertyParserHelpers::parseColorMixFunctionParametersRaw): (WebCore::CSSPropertyParserHelpers::consumePositionCoordinates): (WebCore::CSSPropertyParserHelpers::consumePrefixedRadialGradient): (WebCore::CSSPropertyParserHelpers::consumeRadialGradient): (WebCore::CSSPropertyParserHelpers::consumePrefixedLinearGradient): (WebCore::CSSPropertyParserHelpers::consumeLinearGradient): (WebCore::CSSPropertyParserHelpers::consumeConicGradient): (WebCore::CSSPropertyParserHelpers::consumeSingleShadow): (WebCore::CSSPropertyParserHelpers::consumeFamilyNameList): (WebCore::CSSPropertyParserHelpers::consumeFontVariantEastAsian): (WebCore::CSSPropertyParserHelpers::consumeFontVariantAlternates): (WebCore::CSSPropertyParserHelpers::consumeClip): (WebCore::CSSPropertyParserHelpers::consumeSteps): (WebCore::CSSPropertyParserHelpers::consumeCubicBezier): (WebCore::CSSPropertyParserHelpers::consumeSpringFunction): (WebCore::CSSPropertyParserHelpers::consumeTransformFunction): (WebCore::CSSPropertyParserHelpers::consumeAttr): (WebCore::CSSPropertyParserHelpers::consumeBasicShapePath): (WebCore::CSSPropertyParserHelpers::consumeReflect): (WebCore::CSSPropertyParserHelpers::consumeBackgroundSize): (WebCore::CSSPropertyParserHelpers::consumeAlignTracks): (WebCore::CSSPropertyParserHelpers::consumeJustifyTracks): (WebCore::CSSPropertyParserHelpers::consumeHangingPunctuation): Canonical link: https://commits.webkit.org/262873@main

webkit-commit-queue · 2023-04-12T17:19:55Z

Committed 262873@main (0b6c4aa): https://commits.webkit.org/262873@main

Reviewed commits have been landed. Closing PR #12644 and removing active labels.

annevk self-assigned this Apr 12, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 12, 2023

anttijk approved these changes Apr 12, 2023

View reviewed changes

Ahmad-S792 added CSS Cascading Style Sheets implementation and removed merging-blocked Applied to prevent a change from being merged labels Apr 12, 2023

annevk changed the title ~~limit CSS parser hashless-color and unitless-length quirks to only the properties that need them~~ background-size should not accept unitless lengths Apr 12, 2023

annevk force-pushed the unitless-background-size branch from a7be029 to 5e1b997 Compare April 12, 2023 15:51

annevk added the request-merge-queue Request a pull request to be added to merge-queue once ready label Apr 12, 2023

Ahmad-S792 added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Apr 12, 2023

nt1m requested changes Apr 12, 2023

View reviewed changes

nt1m removed the merge-queue Applied to send a pull request to merge-queue label Apr 12, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 12, 2023

nt1m approved these changes Apr 12, 2023

View reviewed changes

nt1m self-requested a review April 12, 2023 17:03

nt1m added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Apr 12, 2023

webkit-commit-queue force-pushed the unitless-background-size branch from 5e1b997 to 0b6c4aa Compare April 12, 2023 17:19

webkit-commit-queue merged commit 0b6c4aa into WebKit:main Apr 12, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 12, 2023

annevk deleted the unitless-background-size branch April 12, 2023 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

background-size should not accept unitless lengths #12644

background-size should not accept unitless lengths #12644

annevk commented Apr 12, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Apr 12, 2023 •

edited

annevk commented Apr 12, 2023

webkit-early-warning-system commented Apr 12, 2023

webkit-early-warning-system commented Apr 12, 2023 •

edited

nt1m left a comment

nt1m left a comment

webkit-commit-queue commented Apr 12, 2023

background-size should not accept unitless lengths #12644

background-size should not accept unitless lengths #12644

Conversation

annevk commented Apr 12, 2023 • edited by webkit-early-warning-system

0b6c4aa

webkit-early-warning-system commented Apr 12, 2023 • edited

annevk commented Apr 12, 2023

webkit-early-warning-system commented Apr 12, 2023

webkit-early-warning-system commented Apr 12, 2023 • edited

nt1m left a comment

Choose a reason for hiding this comment

nt1m left a comment

Choose a reason for hiding this comment

webkit-commit-queue commented Apr 12, 2023

annevk commented Apr 12, 2023 •

edited by webkit-early-warning-system

`0b6c4aa`

webkit-early-warning-system commented Apr 12, 2023 •

edited

webkit-early-warning-system commented Apr 12, 2023 •

edited