Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] RemoteBuffer unmap should check the input vector #12660

Merged
merged 1 commit into from Apr 13, 2023
Merged

[WebGPU] RemoteBuffer unmap should check the input vector #12660

merged 1 commit into from Apr 13, 2023

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Apr 12, 2023 •
edited by webkit-early-warning-system

54408f5

[WebGPU] RemoteBuffer unmap should check the input vector
https://bugs.webkit.org/show_bug.cgi?id=255350
<rdar://107947502>

Reviewed by Myles C. Maxfield.

Ensure data vector passed to unmap is valid for the currently
mapped buffer.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp:
(WebKit::RemoteBuffer::unmap):

Canonical link: https://commits.webkit.org/262895@main

d4b167f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Apr 12, 2023
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Apr 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d4b167f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Apr 12, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 12, 2023
@mwyrzykowski mwyrzykowski added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Apr 12, 2023
@mwyrzykowski
[WebGPU] RemoteBuffer unmap should check the input vector
54408f5 
https://bugs.webkit.org/show_bug.cgi?id=255350
<rdar://107947502>

Reviewed by Myles C. Maxfield.

Ensure data vector passed to unmap is valid for the currently
mapped buffer.

* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp:
(WebKit::RemoteBuffer::unmap):

Canonical link: https://commits.webkit.org/262895@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-RemoteBuffer-unmap-should-check-the-input-vector branch from d4b167f to 54408f5 Compare April 13, 2023 00:32
@webkit-commit-queue
Copy link
Collaborator

Committed 262895@main (54408f5): https://commits.webkit.org/262895@main

Reviewed commits have been landed. Closing PR #12660 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 54408f5 into WebKit:main Apr 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litherum litherum litherum approved these changes

@djg djg Awaiting requested review from djg

@tadeuzagallo tadeuzagallo Awaiting requested review from tadeuzagallo tadeuzagallo is a code owner

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
5 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @litherum @webkit-ews-buildbot