Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable HEIC decoding for all non-browser apps on macOS #1276

Merged
merged 0 commits into from Jun 3, 2022
Merged

Enable HEIC decoding for all non-browser apps on macOS #1276

merged 0 commits into from Jun 3, 2022

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Jun 3, 2022 •
edited by webkit-early-warning-system

7c2a4a4

Enable HEIC decoding for all non-browser apps on macOS
https://bugs.webkit.org/show_bug.cgi?id=241271
<rdar://92983791 >

Reviewed by Geoffrey Garen.

Enable HEIC decoding for all non-browser apps on macOS, since this capability is also needed for other apps besides Mail.
We do not want to enable it for Web browsers yet, since this currently requries an unconditional sandbox extension for
trustd.

* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/251289@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@pvollan pvollan self-assigned this Jun 3, 2022
@pvollan pvollan added Safari 15 WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). labels Jun 3, 2022
@pvollan pvollan force-pushed the eng/Enable-HEIC-decoding-for-all-non-browser-apps-on-macOS branch from 740a74d to 73ad87c Compare June 3, 2022 16:26
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 3, 2022
geoffreygaren
geoffreygaren approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

Good catch

@pvollan
Copy link
Contributor Author

pvollan commented Jun 3, 2022

r=me

Good catch

Thanks for reviewing!

@pvollan pvollan added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 3, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Enable-HEIC-decoding-for-all-non-browser-apps-on-macOS branch from 73ad87c to 7c2a4a4 Compare June 3, 2022 21:21
@webkit-early-warning-system webkit-early-warning-system merged commit 7c2a4a4 into WebKit:main Jun 3, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295234 (251289@main): https://commits.webkit.org/251289@main

Reviewed commits have been landed. Closing PR #1276 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@nmoucht nmoucht Awaiting requested review from nmoucht

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
3 participants
@pvollan @webkit-early-warning-system @geoffreygaren