Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-cl reports "error: reference to 'UUID' is ambiguous" for Windows port #12784

Merged
merged 1 commit into from Apr 17, 2023
Merged

clang-cl reports "error: reference to 'UUID' is ambiguous" for Windows port #12784

merged 1 commit into from Apr 17, 2023

Conversation

fujii
Copy link
Contributor

@fujii fujii commented Apr 17, 2023 •
edited by webkit-early-warning-system

16e36e6

clang-cl reports "error: reference to 'UUID' is ambiguous" for Windows port
https://bugs.webkit.org/show_bug.cgi?id=234696

Reviewed by Yusuke Suzuki.

Including <windows.h> defines `UUID` in the global scope. This
conflicted with "using WTF::UUID;" in <wtf/Forward.h>. For the
workaround, define `UUID` in each namespace that is using it in
<wtf/Forward.h>.

* Source/WTF/wtf/Forward.h:
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerProviderDidClickNotification_b):

Canonical link: https://commits.webkit.org/263042@main

38abdac

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@fujii fujii requested a review from cdumez as a code owner April 17, 2023 05:03
@fujii fujii self-assigned this Apr 17, 2023
@fujii fujii added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Apr 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash a074a42)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
❌ 🛠 tv-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
❌ 🛠 watch ✅ 🛠 jsc-mips
❌ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 17, 2023
@fujii fujii removed the merging-blocked Applied to prevent a change from being merged label Apr 17, 2023
@fujii fujii force-pushed the eng/ClangWin-NotificationData-h475-error-reference-to-UUID-is-ambiguous branch from a074a42 to 38abdac Compare April 17, 2023 07:43
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 38abdac)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 17, 2023
Constellation
Constellation approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate. But anyway, we need to workaround it.

@fujii fujii added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Apr 17, 2023
@fujii
clang-cl reports "error: reference to 'UUID' is ambiguous" for Window…
16e36e6 
…s port

https://bugs.webkit.org/show_bug.cgi?id=234696

Reviewed by Yusuke Suzuki.

Including <windows.h> defines `UUID` in the global scope. This
conflicted with "using WTF::UUID;" in <wtf/Forward.h>. For the
workaround, define `UUID` in each namespace that is using it in
<wtf/Forward.h>.

* Source/WTF/wtf/Forward.h:
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerProviderDidClickNotification_b):

Canonical link: https://commits.webkit.org/263042@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ClangWin-NotificationData-h475-error-reference-to-UUID-is-ambiguous branch from 38abdac to 16e36e6 Compare April 17, 2023 22:32
@webkit-commit-queue
Copy link
Collaborator

Committed 263042@main (16e36e6): https://commits.webkit.org/263042@main

Reviewed commits have been landed. Closing PR #12784 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 16e36e6 into WebKit:main Apr 17, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 17, 2023
@fujii fujii deleted the eng/ClangWin-NotificationData-h475-error-reference-to-UUID-is-ambiguous branch June 30, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@fujii fujii

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
5 participants
@fujii @webkit-early-warning-system @webkit-commit-queue @Constellation @webkit-ews-buildbot