Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Speedometer plan to use github source #12813

Conversation

@sundiamonde sundiamonde self-assigned this Apr 17, 2023
@sundiamonde sundiamonde added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Apr 17, 2023
@@ -1,9 +1,783 @@
{
"timeout": 600,
"count": 4,
"svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@r290664",
"github_source": "https://github.com/WebKit/WebKit/tree/d0bce574a12b3524176d177f737f324e1694dcfc/PerformanceTests/Speedometer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add "local_git_archive":"PerformanceTests/Speedometer@d0bce574a12b3524176d177f737f324e1694dcfc",
to optimize local running from this repo.

Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with comment.

@sundiamonde sundiamonde force-pushed the eng/Update-Speedometer-plan-to-use-github-source branch from 0760454 to 2b18884 Compare April 17, 2023 18:49
@sundiamonde sundiamonde added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Apr 17, 2023
@sundiamonde sundiamonde force-pushed the eng/Update-Speedometer-plan-to-use-github-source branch from 2b18884 to 5252882 Compare April 17, 2023 19:59
@sundiamonde sundiamonde added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 17, 2023
https://bugs.webkit.org/show_bug.cgi?id=255534
rdar://108148657

Reviewed by Dewei Zhu.

* Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.1.plan:

Canonical link: https://commits.webkit.org/263034@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Update-Speedometer-plan-to-use-github-source branch from 5252882 to a57b46b Compare April 17, 2023 20:09
@webkit-commit-queue
Copy link
Collaborator

Committed 263034@main (a57b46b): https://commits.webkit.org/263034@main

Reviewed commits have been landed. Closing PR #12813 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a57b46b into WebKit:main Apr 17, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants