Remove respondsToSelector check in CDMInstanceFairPlayStreamingAVFObjC #12842

AtariDreams · 2023-04-18T02:57:15Z

Remove respondsToSelector check in CDMInstanceFairPlayStreamingAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=255575

Reviewed by NOBODY (OOPS!).

We no longer support macOS 10.14.4, so we can remove the
respondsToSelector check meant for earlier macOS versions.

* Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
  (WebCore::initTypeForRequest):

9b3b64d

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T02:57:25Z

EWS run on previous version of this PR (hash bce0192)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T03:10:27Z

EWS run on previous version of this PR (hash 21512be)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	~~🧪 mac-wk2~~	⏳ 🧪 api-gtk
	~~🛠 tv~~	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T03:20:29Z

EWS run on previous version of this PR (hash 8cff07c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	❌ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T03:47:12Z

EWS run on previous version of this PR (hash abb8ff2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	❌ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	~~🛠 mac-AS-debug~~	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	❌ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	❌ 🧪 mac-wk1	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	❌ 🧪 mac-wk2	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T03:54:41Z

EWS run on previous version of this PR (hash a31cdeb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T13:12:19Z

EWS run on previous version of this PR (hash 765eb29)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T16:48:19Z

EWS run on previous version of this PR (hash 42b1c34)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-18T19:20:59Z

EWS run on previous version of this PR (hash fb3cf5d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-04-19T14:26:46Z

EWS run on previous version of this PR (hash be58049)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-04-19T14:34:50Z

EWS run on previous version of this PR (hash 5dd6c35)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=255575 Reviewed by NOBODY (OOPS!). We no longer support macOS 10.14.4, so we can remove the respondsToSelector check meant for earlier macOS versions. * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::initTypeForRequest): (WebCore::groupForRequest):

webkit-early-warning-system · 2023-04-19T15:50:40Z

EWS run on current version of this PR (hash 9b3b64d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

AtariDreams force-pushed the CDM branch from bce0192 to 21512be Compare April 18, 2023 03:10

AtariDreams force-pushed the CDM branch from 21512be to 8cff07c Compare April 18, 2023 03:20

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 18, 2023

AtariDreams force-pushed the CDM branch from 8cff07c to abb8ff2 Compare April 18, 2023 03:47

AtariDreams force-pushed the CDM branch from abb8ff2 to a31cdeb Compare April 18, 2023 03:54

AtariDreams force-pushed the CDM branch from a31cdeb to 765eb29 Compare April 18, 2023 13:12

AtariDreams force-pushed the CDM branch from 765eb29 to 42b1c34 Compare April 18, 2023 16:36

AtariDreams force-pushed the CDM branch from 42b1c34 to fb3cf5d Compare April 18, 2023 18:57

AtariDreams force-pushed the CDM branch from fb3cf5d to be58049 Compare April 19, 2023 14:23

AtariDreams force-pushed the CDM branch from be58049 to 5dd6c35 Compare April 19, 2023 14:27

AtariDreams force-pushed the CDM branch from 5dd6c35 to 9b3b64d Compare April 19, 2023 15:35

justinmichaud added the skip-ews Applied to prevent a change from being run on EWS label May 3, 2023

AtariDreams closed this May 31, 2023

AtariDreams deleted the CDM branch May 31, 2023 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove respondsToSelector check in CDMInstanceFairPlayStreamingAVFObjC #12842

Remove respondsToSelector check in CDMInstanceFairPlayStreamingAVFObjC #12842

AtariDreams commented Apr 18, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 19, 2023 •

edited

webkit-early-warning-system commented Apr 19, 2023 •

edited

webkit-early-warning-system commented Apr 19, 2023 •

edited

Remove respondsToSelector check in CDMInstanceFairPlayStreamingAVFObjC #12842

Remove respondsToSelector check in CDMInstanceFairPlayStreamingAVFObjC #12842

Conversation

AtariDreams commented Apr 18, 2023 • edited by webkit-early-warning-system

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 18, 2023 • edited

webkit-early-warning-system commented Apr 19, 2023 • edited

webkit-early-warning-system commented Apr 19, 2023 • edited

webkit-early-warning-system commented Apr 19, 2023 • edited

AtariDreams commented Apr 18, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 18, 2023 •

edited

webkit-early-warning-system commented Apr 19, 2023 •

edited

webkit-early-warning-system commented Apr 19, 2023 •

edited

webkit-early-warning-system commented Apr 19, 2023 •

edited