Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-cl reports "error: reference to 'UUID' is ambiguous" for Windows port #12843

Closed
wants to merge 1 commit into from
Closed

clang-cl reports "error: reference to 'UUID' is ambiguous" for Windows port #12843

wants to merge 1 commit into from

Conversation

fujii
Copy link
Contributor

@fujii fujii commented Apr 18, 2023 •
edited by webkit-early-warning-system

ee81fa1

clang-cl reports "error: reference to 'UUID' is ambiguous" for Windows port
https://bugs.webkit.org/show_bug.cgi?id=234696

Reviewed by NOBODY (OOPS!).

Including <windows.h> defines `UUID` in the global scope. This
conflicted with "using WTF::UUID;" in <wtf/Forward.h>. For the
workaround, define `UUID` in each namespace that is using it in
<wtf/Forward.h> for OS(WINDOWS).

* Source/WTF/wtf/Forward.h:
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerProviderDidClickNotification_b):

ee81fa1

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@fujii
clang-cl reports "error: reference to 'UUID' is ambiguous" for Window…
ee81fa1 
…s port

https://bugs.webkit.org/show_bug.cgi?id=234696

Reviewed by NOBODY (OOPS!).

Including <windows.h> defines `UUID` in the global scope. This
conflicted with "using WTF::UUID;" in <wtf/Forward.h>. For the
workaround, define `UUID` in each namespace that is using it in
<wtf/Forward.h> for OS(WINDOWS).

* Source/WTF/wtf/Forward.h:
* Source/WebKit/UIProcess/API/APIUserInitiatedAction.h:
* Source/WebKit/UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerProviderDidClickNotification_b):
@fujii fujii requested a review from cdumez as a code owner April 18, 2023 03:27
@fujii fujii self-assigned this Apr 18, 2023
@fujii fujii added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Apr 18, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ee81fa1)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@fujii
Copy link
Contributor Author

fujii commented Jul 5, 2023

Let's try another approach in #15553. Closed.

@fujii fujii closed this Jul 5, 2023
@fujii fujii deleted the eng/Bug234696-using-WTF-UUID-namespaces-for-Windows branch July 14, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@Constellation Constellation Awaiting requested review from Constellation

@donny-dont donny-dont Awaiting requested review from donny-dont

@rkirsling rkirsling Awaiting requested review from rkirsling

Assignees

@fujii fujii

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
2 participants
@fujii @webkit-early-warning-system