[WGSL] Serialize global overrides #12860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 8a47a9e)
|
webkit-ews-buildbot
added
the
merging-blocked
litherum
reviewed
Apr 18, 2023
| return; | ||
|
|
||
| m_stringBuilder.append("constant "); | ||
| serializeVariable(variable); |
There was a problem hiding this comment.
Where is the validation that only certain types are allowed to be function constants?
Where is this tested?
There was a problem hiding this comment.
We have basically no validation of that sort yet. We could test by matching the metal output, but behavior tests won't work yet since we still need one more patch to get overrides to actually work.
litherum
approved these changes
Apr 18, 2023
tadeuzagallo
force-pushed
the
eng/WGSL-Serialize-global-overrides
branch
from
8a47a9e
to
1c015db
Compare
tadeuzagallo
added
merge-queue
|
EWS run on current version of this PR (hash 1c015db)
|
https://bugs.webkit.org/show_bug.cgi?id=255600 rdar://108197601 Reviewed by Myles C. Maxfield. Add serialization support for override declarations. Notice that we temporarily disable the mangling of globals, which ironically wasn't being used yet, but requires notifying the API about the mangling. I will be implementing that next and will re-enable the mangling. * Source/WebGPU/WGSL/MangleNames.cpp: (WGSL::NameManglerVisitor::visit): * Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp: (WGSL::Metal::FunctionDefinitionWriter::write): (WGSL::Metal::FunctionDefinitionWriter::visit): (WGSL::Metal::FunctionDefinitionWriter::visitGlobal): (WGSL::Metal::FunctionDefinitionWriter::serializeVariable): Canonical link: https://commits.webkit.org/263167@main
webkit-commit-queue
force-pushed
the
eng/WGSL-Serialize-global-overrides
branch
from
1c015db
to
e8be4ea
Compare
|
Committed 263167@main (e8be4ea): https://commits.webkit.org/263167@main Reviewed commits have been landed. Closing PR #12860 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e8be4ea
1c015db
🧪 gtk-wk2🧪 mac-wk2🧪 mac-AS-debug-wk2