Web Inspector: Upstream Safari 16.4 user agents #12898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 0d19995) |
dcrousso
approved these changes
Apr 19, 2023
| @@ -102,6 +102,7 @@ localizedStrings["0 Console warnings"] = "0 Console warnings"; | |||
| localizedStrings["1 match"] = "1 match"; | |||
| localizedStrings["1080p"] = "1080p"; | |||
| localizedStrings["2D"] = "2D"; | |||
| localizedStrings["2D (Offscreen)"] = "2D (Offscreen)"; | |||
There was a problem hiding this comment.
Confused as to why this change was made?
There was a problem hiding this comment.
The strings file is generated using a script, so this indicates that these strings were missing from the file previously.
| /* Label for a preference that is turned off. */ | ||
| localizedStrings["Off @ User Preferences Overrides"] = "Off"; | ||
| localizedStrings["Offscreen2D"] = "Offscreen2D"; |
https://bugs.webkit.org/show_bug.cgi?id=255636 rdar://105254961 Reviewed by Devin Rousso. * Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js: * Source/WebInspectorUI/UserInterface/Views/OverrideDeviceSettingsPopover.js: (WI.OverrideDeviceSettingsPopover.prototype._createUserAgentSection): Canonical link: https://commits.webkit.org/263319@main
webkit-commit-queue
force-pushed
the
eng/b255636-upstream-safari-16-4-uas
branch
from
0d19995
to
91a1d20
Compare
|
Committed 263319@main (91a1d20): https://commits.webkit.org/263319@main Reviewed commits have been landed. Closing PR #12898 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
91a1d20
0d19995