-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSC] Skip ProxyObject's ICs trap result validation in the common case #12919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shvaikalesh
added
the
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
label
Apr 19, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 19, 2023
shvaikalesh
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 20, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 20, 2023
Constellation
requested changes
Apr 20, 2023
shvaikalesh
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 21, 2023
shvaikalesh
changed the title
[JSC] Skip result validation in some of the ProxyObject's traps for most targets
[JSC] Skip ProxyObject's ICs trap result validation in the common case
Apr 21, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 21, 2023
shvaikalesh
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 21, 2023
Constellation
requested changes
Apr 21, 2023
shvaikalesh
force-pushed
the
bug-255661
branch
2 times, most recently
from
April 21, 2023 20:41
6297086
to
54f6eb8
Compare
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 22, 2023
shvaikalesh
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 23, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 23, 2023
shvaikalesh
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Apr 25, 2023
Constellation
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with comments
shvaikalesh
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Apr 27, 2023
https://bugs.webkit.org/show_bug.cgi?id=255661 <rdar://problem/108269769> Reviewed by Yusuke Suzuki. Invariants of the essential internal methods [1] are enforced for all objects, both ordinary and exotic, to avoid them having unpredictable behavior that negatively impacts developer experience and creates security issues. Enforcing them for Proxy objects is especially cumbersome, given traps are userland code, and quite expensive performance-wise: invariants invalidation requires checking property attributes, which currently requires JS => C++ call. After carefully analyzing all the invariants of the all internal methods, it was concluded that if [[ProxyTarget]] is an ordinary extensible object without non-configurable properties, validation of the invariants can be safely (non-observably) skipped. trap name IC attributes checked ======================== == ================================== getOwnPropertyDescriptor no non-configurable || non-extensible defineProperty no non-configurable || non-extensible has yes non-configurable || non-extensible get yes non-configurable && (non-writable || accessor) set yes non-configurable && (non-writable || accessor) deleteProperty maybe non-configurable || non-extensible ownKeys no non-configurable || non-extensible This change: 1. Introduces OverridesIsExtensible out-of-line type info flag to tighten Structure's didPreventExtensions() flag, making it more pessimistic: it being `true` doesn't necessarily mean the structure is non-extensible, but the reverse of it being `false` can be safely relied on. It's not a completely new approach: WebKit#11843 does the same thing. This change was proved not to introduce bugs since Structure's didPreventExtensions() flag is currently checked only for objects without isExtensible() override. 2. Introduces hasNonConfigurableProperties and hasNonConfigurableReadOnlyOrGetterSetterProperties Structure flags that are also pessimistic. When inferring their initial values, we do extra care not to be overly pessimistic for objects except JSFinalObject by checking overridesGetOwnPropertySlot() so that userland code, which heavily uses Map / Set as [[ProxyTarget]], more performant, while making an exception for JSArray's non-configurable non-structure "length" property. While there is existing hasReadOnlyOrGetterSetterPropertiesExcludingProto flag, we can't combine it with hasNonConfigurableProperties because MobX installs a non-writable administration property even on arrays, which have non-configurable "length" already, so combining them would disable optimization for JSArray. 3. Introduces HasStructureWithFlags bytecode op to be utilized in ProxyObject IC helpers to skip trap result validation for most of ProxyObject's targets. In the follow-ups, this approach will be expanded to C++ code. Currently, due to lack of proper profiling of GetInternalField results, constant folding for HasStructureWithFlags doesn't work in microbenchmarks. ToT patch proxy-has-miss 159.9825+-2.4190 ^ 43.1435+-0.5994 ^ definitely 3.7082x faster proxy-set-miss-handler 158.7617+-2.3615 ^ 139.2158+-1.9197 ^ definitely 1.1404x faster proxy-set 125.5967+-1.3678 ^ 14.4533+-0.1739 ^ definitely 8.6898x faster proxy-get 115.8061+-2.2413 ^ 14.2136+-0.1138 ^ definitely 8.1475x faster <geometric> 138.5985+-0.9526 ^ 33.3237+-0.2255 ^ definitely 4.1592x faster [1]: https://tc39.es/ecma262/#sec-invariants-of-the-essential-internal-methods * Source/JavaScriptCore/builtins/BuiltinNames.h: * Source/JavaScriptCore/builtins/ProxyHelpers.js: (linkTimeConstant.performProxyObjectHas): (linkTimeConstant.performProxyObjectGet): (linkTimeConstant.performProxyObjectSetSloppy): (linkTimeConstant.performProxyObjectSetStrict): * Source/JavaScriptCore/bytecode/BytecodeIntrinsicRegistry.h: * Source/JavaScriptCore/bytecode/BytecodeList.rb: * Source/JavaScriptCore/bytecode/BytecodeUseDef.cpp: (JSC::computeUsesForBytecodeIndexImpl): (JSC::computeDefsForBytecodeIndexImpl): * Source/JavaScriptCore/bytecode/LinkTimeConstant.h: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitHasStructureWithFlags): * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h: * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::BytecodeIntrinsicNode::emit_intrinsic_mustValidateResultOfProxyGetAndSetTraps): (JSC::BytecodeIntrinsicNode::emit_intrinsic_mustValidateResultOfProxyTrapsExceptGetAndSet): * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * Source/JavaScriptCore/dfg/DFGClobberize.h: (JSC::DFG::clobberize): * Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants): * Source/JavaScriptCore/dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * Source/JavaScriptCore/dfg/DFGHeapLocation.cpp: (WTF::printInternal): * Source/JavaScriptCore/dfg/DFGHeapLocation.h: * Source/JavaScriptCore/dfg/DFGNode.h: (JSC::DFG::Node::structureFlags): * Source/JavaScriptCore/dfg/DFGNodeType.h: * Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp: * Source/JavaScriptCore/dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h: * Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * Source/JavaScriptCore/ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileNode): (JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq): * Source/JavaScriptCore/jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): * Source/JavaScriptCore/jit/JIT.h: * Source/JavaScriptCore/jit/JITOpcodes.cpp: (JSC::JIT::emit_op_has_structure_with_flags): * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): * Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): (JSC::globalFuncHandleProxySetTrapResult): Deleted. * Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.h: * Source/JavaScriptCore/runtime/JSTypeInfo.h: (JSC::TypeInfo::overridesIsExtensible const): * Source/JavaScriptCore/runtime/PropertySlot.h: * Source/JavaScriptCore/runtime/ProxyObject.cpp: (JSC::ProxyObject::performPut): (JSC::ProxyObject::validatePositiveSetTrapResult): (JSC::ProxyObject::validateSetTrapResult): Deleted. * Source/JavaScriptCore/runtime/ProxyObject.h: * Source/JavaScriptCore/runtime/Structure.cpp: (JSC::Structure::validateFlags): (JSC::Structure::Structure): (JSC::Structure::nonPropertyTransitionSlow): * Source/JavaScriptCore/runtime/Structure.h: (JSC::Structure::isNonExtensibleOrHasNonConfigurableProperties const): (JSC::Structure::bitField const): * Source/JavaScriptCore/runtime/StructureInlines.h: (JSC::Structure::add): (JSC::Structure::attributeChange): * Source/JavaScriptCore/wasm/js/WebAssemblyGCObjectBase.h: * Source/WebCore/bindings/js/JSDOMWindowProperties.h: Canonical link: https://commits.webkit.org/263443@main
webkit-commit-queue
force-pushed
the
bug-255661
branch
from
April 27, 2023 03:06
a2d277d
to
18d9fef
Compare
Committed 263443@main (18d9fef): https://commits.webkit.org/263443@main Reviewed commits have been landed. Closing PR #12919 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
JavaScriptCore
For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18d9fef
a2d277d
π§ͺ gtk-wk2