[WebGPU] Implement GPUAdapter.requestAdapterInfo #12923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webkit-ews-buildbot
added
the
merging-blocked
|
EWS run on previous version of this PR (hash fa46428)
|
mwyrzykowski
removed
the
merging-blocked
mwyrzykowski
force-pushed
the
eng/WebGPU-Implement-GPUAdapter-requestAdapterInfo
branch
from
fa46428
to
2dca057
Compare
|
EWS run on previous version of this PR (hash 2dca057) |
litherum
reviewed
Apr 20, 2023
| @@ -72,8 +73,7 @@ void GPUAdapter::requestDevice(ScriptExecutionContext&, const std::optional<GPUD | |||
|
|
|||
| void GPUAdapter::requestAdapterInfo(const std::optional<Vector<String>>&, RequestAdapterInfoPromise&& promise) | |||
| { | |||
| // FIXME: https://bugs.webkit.org/show_bug.cgi?id=251377 - [WebGPU] Implement GPUAdapter.requestAdapterInfo | |||
| promise.resolve(nullptr); | |||
| promise.resolve(GPUAdapterInfo::create()); | |||
There was a problem hiding this comment.
I'm not sure this is sufficient - we will probably want this to be more complicated in the future.
I think we should have device creation automatically report this info from the GPU Process to the web process - like how limits and features are already handled
There was a problem hiding this comment.
WebGPUAdapter already has an adapter name, we could likely use this directly to populate at least one of the GPUAdapterInfo fields, I will do that for now. We can expand upon it as needed in the future
litherum
approved these changes
Apr 20, 2023
mwyrzykowski
force-pushed
the
eng/WebGPU-Implement-GPUAdapter-requestAdapterInfo
branch
from
2dca057
to
4b42a81
Compare
|
EWS run on previous version of this PR (hash 4b42a81)
|
mwyrzykowski
force-pushed
the
eng/WebGPU-Implement-GPUAdapter-requestAdapterInfo
branch
from
4b42a81
to
a2b6895
Compare
|
EWS run on current version of this PR (hash a2b6895) |
https://bugs.webkit.org/show_bug.cgi?id=251377 <radar://104829439> Reviewed by Myles C. Maxfield. Minimally implement requestAdapterInfo, so https://mlc.ai/web-llm/ does not report an error about output.adapterInfo.description being undefined. * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/WebGPU/GPUAdapter.cpp: (WebCore::GPUAdapter::requestAdapterInfo): * Source/WebCore/Modules/WebGPU/GPUAdapter.h: * Source/WebCore/Modules/WebGPU/GPUAdapter.idl: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/bindings/js/WebCoreBuiltinNames.h: * Source/WebCore/Modules/WebGPU/GPUAdapterInfo.h: Added. (WebCore::GPUAdapterInfo::create): (WebCore::GPUAdapterInfo::vendor const): (WebCore::GPUAdapterInfo::architecture const): (WebCore::GPUAdapterInfo::device const): (WebCore::GPUAdapterInfo::description const): (WebCore::GPUAdapterInfo::GPUAdapterInfo): * Source/WebCore/Modules/WebGPU/GPUAdapterInfo.idl: Added. Add new files. Canonical link: https://commits.webkit.org/263164@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Implement-GPUAdapter-requestAdapterInfo
branch
from
a2b6895
to
1e0ff03
Compare
|
Committed 263164@main (1e0ff03): https://commits.webkit.org/263164@main Reviewed commits have been landed. Closing PR #12923 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1e0ff03
a2b6895
🧪 gtk-wk2🧪 mac-AS-debug-wk2