Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add css-fonts-5 to CSSProperties categories #13021

Merged
merged 1 commit into from Apr 21, 2023
Merged

Add css-fonts-5 to CSSProperties categories #13021

merged 1 commit into from Apr 21, 2023

Conversation

vitorroriz
Copy link
Contributor

@vitorroriz vitorroriz commented Apr 21, 2023 •
edited by webkit-early-warning-system

15c23ee

Add css-fonts-5 to CSSProperties categories
https://bugs.webkit.org/show_bug.cgi?id=255776
rdar://108362775

Reviewed by Alan Baradlay.

Add css-fonts-5 to CSSProperties categories so it can be used by properties implemented in that level.

* Source/WebCore/css/CSSProperties.json:

Canonical link: https://commits.webkit.org/263238@main

e9d2cc9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@vitorroriz vitorroriz self-assigned this Apr 21, 2023
@vitorroriz vitorroriz added the CSS Cascading Style Sheets implementation label Apr 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash e9d2cc9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

alanbaradlay
alanbaradlay approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@alanbaradlay alanbaradlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@vitorroriz vitorroriz added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 21, 2023
@vitorroriz
Add css-fonts-5 to CSSProperties categories
15c23ee 
https://bugs.webkit.org/show_bug.cgi?id=255776
rdar://108362775

Reviewed by Alan Baradlay.

Add css-fonts-5 to CSSProperties categories so it can be used by properties implemented in that level.

* Source/WebCore/css/CSSProperties.json:

Canonical link: https://commits.webkit.org/263238@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add-css-fonts-5-to-CSSProperties-categories branch from e9d2cc9 to 15c23ee Compare April 21, 2023 13:37
@webkit-commit-queue
Copy link
Collaborator

Committed 263238@main (15c23ee): https://commits.webkit.org/263238@main

Reviewed commits have been landed. Closing PR #13021 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 15c23ee into WebKit:main Apr 21, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanbaradlay alanbaradlay alanbaradlay approved these changes

Assignees

@vitorroriz vitorroriz

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
4 participants
@vitorroriz @webkit-early-warning-system @webkit-commit-queue @alanbaradlay