Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PKPaymentMethod and NSMutableURLRequest to Secure mode #13034

Merged
merged 1 commit into from Apr 21, 2023
Merged

Move PKPaymentMethod and NSMutableURLRequest to Secure mode #13034

merged 1 commit into from Apr 21, 2023

Conversation

gavin-apple
Copy link
Contributor

@gavin-apple gavin-apple commented Apr 21, 2023 •
edited by webkit-early-warning-system

0819d58

Move PKPaymentMethod and NSMutableURLRequest to Secure mode
https://bugs.webkit.org/show_bug.cgi?id=255791
rdar://108235706

Reviewed by Wenson Hsieh.

Move PKPaymentMethod & NSMutableURLRequest to using Secure mode
for deserialization.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::shouldEnableStrictMode):

Canonical link: https://commits.webkit.org/263256@main

a6cf77a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@gavin-apple gavin-apple self-assigned this Apr 21, 2023
@gavin-apple gavin-apple added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Apr 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash c7b45be)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@gavin-apple gavin-apple changed the title Move PKPaymentMethod to Secure mode Move PKPaymentMethod and NSMutableURLRequest to Secure mode Apr 21, 2023
@gavin-apple gavin-apple force-pushed the eng/Move-PKPaymentMethod-to-Secure-mode branch from c7b45be to f98af84 Compare April 21, 2023 16:52
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash f98af84)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@gavin-apple gavin-apple force-pushed the eng/Move-PKPaymentMethod-to-Secure-mode branch from f98af84 to a6cf77a Compare April 21, 2023 17:15
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a6cf77a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@gavin-apple gavin-apple added the merge-queue Applied to send a pull request to merge-queue label Apr 21, 2023
@gavin-apple
Move PKPaymentMethod and NSMutableURLRequest to Secure mode
0819d58 
https://bugs.webkit.org/show_bug.cgi?id=255791
rdar://108235706

Reviewed by Wenson Hsieh.

Move PKPaymentMethod & NSMutableURLRequest to using Secure mode
for deserialization.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::shouldEnableStrictMode):

Canonical link: https://commits.webkit.org/263256@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Move-PKPaymentMethod-to-Secure-mode branch from a6cf77a to 0819d58 Compare April 21, 2023 19:05
@webkit-commit-queue
Copy link
Collaborator

Committed 263256@main (0819d58): https://commits.webkit.org/263256@main

Reviewed commits have been landed. Closing PR #13034 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0819d58 into WebKit:main Apr 21, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

Assignees

@gavin-apple gavin-apple

Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
Milestone
No milestone
4 participants
@gavin-apple @webkit-early-warning-system @webkit-commit-queue @whsieh