Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Convert bugzilla requests to Twisted requests #13060

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Apr 22, 2023

0c4be16

[ews-build.webkit.org] Convert bugzilla requests to Twisted requests
https://bugs.webkit.org/show_bug.cgi?id=255819
rdar://108392365

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.fetch_data_from_url_with_authentication_bugzilla): Use Twisted requests,
make function asynchronous.
(BugzillaMixin.get_patch_json): Make function asynchronous.
(BugzillaMixin.get_bug_json): Ditto.
(BugzillaMixin.get_bug_id_from_patch): Ditto.
(BugzillaMixin._is_patch_obsolete): Treat get_patch_json as asynchronous.
(BugzillaMixin._is_patch_review_denied): Ditto.
(BugzillaMixin._is_patch_cq_plus): Ditto.
(BugzillaMixin._does_patch_have_acceptable_review_flag): Ditto.
(BugzillaMixin._is_bug_closed): Treat get_bug_json as asynchronous.
(BugzillaMixin.should_send_email_for_patch): Treat get_patch_json as asynchronous.
(ValidateChange.validate_bugzilla):
(BugzillaMixin.fetch_data_from_url): Deleted.

Canonical link: https://commits.webkit.org/263640@main

dbe62f1

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ§ͺ services βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@JonWBedard JonWBedard self-assigned this Apr 22, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Apr 22, 2023
@JonWBedard
Copy link
Member Author

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 3, 2023
https://bugs.webkit.org/show_bug.cgi?id=255819
rdar://108392365

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.fetch_data_from_url_with_authentication_bugzilla): Use Twisted requests,
make function asynchronous.
(BugzillaMixin.get_patch_json): Make function asynchronous.
(BugzillaMixin.get_bug_json): Ditto.
(BugzillaMixin.get_bug_id_from_patch): Ditto.
(BugzillaMixin._is_patch_obsolete): Treat get_patch_json as asynchronous.
(BugzillaMixin._is_patch_review_denied): Ditto.
(BugzillaMixin._is_patch_cq_plus): Ditto.
(BugzillaMixin._does_patch_have_acceptable_review_flag): Ditto.
(BugzillaMixin._is_bug_closed): Treat get_bug_json as asynchronous.
(BugzillaMixin.should_send_email_for_patch): Treat get_patch_json as asynchronous.
(ValidateChange.validate_bugzilla):
(BugzillaMixin.fetch_data_from_url): Deleted.

Canonical link: https://commits.webkit.org/263640@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ews-build-webkit-org-Convert-bugzilla-requests-to-Twisted-requests branch from dbe62f1 to 0c4be16 Compare May 3, 2023 18:37
@webkit-commit-queue
Copy link
Collaborator

Committed 263640@main (0c4be16): https://commits.webkit.org/263640@main

Reviewed commits have been landed. Closing PR #13060 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0c4be16 into WebKit:main May 3, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 3, 2023
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Convert-bugzilla-requests-to-Twisted-requests branch May 4, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants