Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Four http/tests/security/webaudio-render-remote-audio tests are a consistent timeout #13102

Merged
merged 1 commit into from Apr 24, 2023
Merged

Four http/tests/security/webaudio-render-remote-audio tests are a consistent timeout #13102

merged 1 commit into from Apr 24, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Apr 24, 2023 •
edited by webkit-early-warning-system

326243b

Four http/tests/security/webaudio-render-remote-audio tests are a consistent timeout
https://bugs.webkit.org/show_bug.cgi?id=255870
rdar://107687994

Reviewed by Geoffrey Garen.

Allow SYS_mach_eventlink_signal_wait_until & SYS_mach_eventlink_wait_until in the
GPUProcess sandbox to address sandbox violations during those tests.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/263315@main

c848125

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Apr 24, 2023
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Apr 24, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c848125)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

geoffreygaren
geoffreygaren approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 24, 2023
@cdumez
Four http/tests/security/webaudio-render-remote-audio tests are a con…
326243b 
…sistent timeout

https://bugs.webkit.org/show_bug.cgi?id=255870
rdar://107687994

Reviewed by Geoffrey Garen.

Allow SYS_mach_eventlink_signal_wait_until & SYS_mach_eventlink_wait_until in the
GPUProcess sandbox to address sandbox violations during those tests.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:

Canonical link: https://commits.webkit.org/263315@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263315@main (326243b): https://commits.webkit.org/263315@main

Reviewed commits have been landed. Closing PR #13102 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 326243b into WebKit:main Apr 24, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@brentfulgham brentfulgham Awaiting requested review from brentfulgham brentfulgham is a code owner

@pvollan pvollan Awaiting requested review from pvollan pvollan is a code owner

Assignees

@cdumez cdumez

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @geoffreygaren