Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the build #13159

Merged
merged 1 commit into from Apr 25, 2023
Merged

Fix the build #13159

merged 1 commit into from Apr 25, 2023

Conversation

hortont424
Copy link
Contributor

@hortont424 hortont424 commented Apr 25, 2023 •
edited by webkit-early-warning-system

@hortont424 hortont424 self-assigned this Apr 25, 2023
@hortont424 hortont424 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Apr 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4ff3779)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
  🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@hortont424 hortont424 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 25, 2023
@hortont424
Fix the build
ec6cecd 
https://bugs.webkit.org/show_bug.cgi?id=255938
rdar://108513290

Unreviewed build fix.

* Source/WebKit/mac/replace-webkit-additions-includes.py:
(check_should_do_replacement):

Canonical link: https://commits.webkit.org/263386@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263386@main (ec6cecd): https://commits.webkit.org/263386@main

Reviewed commits have been landed. Closing PR #13159 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ec6cecd into WebKit:main Apr 25, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

Assignees

@hortont424 hortont424

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@hortont424 @webkit-early-warning-system @webkit-commit-queue @whsieh