Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WKContentView has an entire screen sized offscreen render pass #13221

Closed
wants to merge 1 commit into from
Closed

WKContentView has an entire screen sized offscreen render pass #13221

wants to merge 1 commit into from

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Apr 27, 2023 •
edited by webkit-early-warning-system

b9226d4

WKContentView has an entire screen sized offscreen render pass
https://bugs.webkit.org/show_bug.cgi?id=256016
<radar://108572186>

Reviewed by NOBODY (OOPS!).

Avoid the fullscreen offscreen render pass by setting allowsGroupBlending
to NO on iOS.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):

b9226d4

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski
WKContentView has an entire screen sized offscreen render pass
b9226d4 
https://bugs.webkit.org/show_bug.cgi?id=256016
<radar://108572186>

Reviewed by NOBODY (OOPS!).

Avoid the fullscreen offscreen render pass by setting allowsGroupBlending
to NO on iOS.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
@mwyrzykowski mwyrzykowski self-assigned this Apr 27, 2023
@mwyrzykowski mwyrzykowski added the Layout and Rendering For bugs with layout and rendering of Web pages. label Apr 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash b9226d4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 27, 2023
@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Apr 27, 2023
@mwyrzykowski mwyrzykowski deleted the eng/WKContentView-has-an-entire-screen-sized-offscreen-render-pass branch April 27, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@mwyrzykowski mwyrzykowski

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
3 participants
@mwyrzykowski @webkit-early-warning-system @webkit-ews-buildbot