Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not handle context menu events when pointer is locked #13222

Merged
merged 1 commit into from Apr 28, 2023
Merged

Do not handle context menu events when pointer is locked #13222

merged 1 commit into from Apr 28, 2023

Conversation

aprotyas
Copy link
Member

@aprotyas aprotyas commented Apr 27, 2023 •
edited by webkit-early-warning-system

54d5339

Do not handle context menu events when pointer is locked
https://bugs.webkit.org/show_bug.cgi?id=256024
rdar://103961310

Reviewed by Wenson Hsieh.

When pointer lock is active, we do not want to show the context menu.
This commit achieves said behavior by not handling context menu events
when the pointer is locked in a page.

* LayoutTests/pointer-lock/mouse-event-delivery-expected.txt:
* LayoutTests/pointer-lock/mouse-event-delivery.html:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):

Canonical link: https://commits.webkit.org/263475@main

64b76ff

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@aprotyas aprotyas requested a review from cdumez as a code owner April 27, 2023 03:20
@aprotyas aprotyas self-assigned this Apr 27, 2023
@aprotyas aprotyas added the UI Events For bugs related to user interactions like keyboard, mouse, and touch events. label Apr 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 7ede477)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

whsieh
whsieh approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@whsieh whsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=mews

Source/WebCore/page/EventHandler.cpp Outdated Show resolved Hide resolved
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 27, 2023
@aprotyas aprotyas removed the merging-blocked Applied to prevent a change from being merged label Apr 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for 64b76ff. Live statuses available at the PR page, #13222

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 64b76ff)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 27, 2023
@whsieh whsieh added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Apr 28, 2023
@aprotyas @whsieh
Do not handle context menu events when pointer is locked
54d5339 
https://bugs.webkit.org/show_bug.cgi?id=256024
rdar://103961310

Reviewed by Wenson Hsieh.

When pointer lock is active, we do not want to show the context menu.
This commit achieves said behavior by not handling context menu events
when the pointer is locked in a page.

* LayoutTests/pointer-lock/mouse-event-delivery-expected.txt:
* LayoutTests/pointer-lock/mouse-event-delivery.html:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEvent):

Canonical link: https://commits.webkit.org/263475@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263475@main (54d5339): https://commits.webkit.org/263475@main

Reviewed commits have been landed. Closing PR #13222 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 54d5339 into WebKit:main Apr 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 28, 2023
@aprotyas aprotyas deleted the eng/103961310 branch April 28, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@hortont424 hortont424 Awaiting requested review from hortont424

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

@rr-codes rr-codes Awaiting requested review from rr-codes

@megangardner megangardner Awaiting requested review from megangardner

Assignees

@aprotyas aprotyas

Labels
UI Events For bugs related to user interactions like keyboard, mouse, and touch events.
Projects
None yet
Milestone
No milestone
5 participants
@aprotyas @webkit-early-warning-system @webkit-commit-queue @whsieh @webkit-ews-buildbot