Web Inspector: Crash when inspecting CSS Grid without defined columns or rows #13260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 39e74ad) |
dcrousso
approved these changes
Apr 28, 2023
| @@ -1441,7 +1441,7 @@ static Vector<String> authoredGridTrackSizes(Node* node, GridTrackSizingDirectio | |||
| } | |||
| } | |||
|
|
|||
| auto* cssValueList = dynamicDowncast<CSSValueList>(*cssValue); | |||
| auto* cssValueList = dynamicDowncast<CSSValueList>(cssValue.get()); | |||
There was a problem hiding this comment.
do we need to .get()? or can we just dynamicDowncast<CSSValueList>(cssValue)?
There was a problem hiding this comment.
Yeah, we need the .get() here, otherwise we try to downcast the RefPtr itself to CSSValueList, which doesn't compile 😅
| @@ -7,6 +7,14 @@ | |||
| { | |||
| let suite = InspectorTest.createAsyncSuite("DOM.showGridOverlay"); | |||
|
|
|||
| const allEnabledOverlayOptions = { | |||
There was a problem hiding this comment.
i wonder if we should do this for the flex overlay too?
patrickangle
force-pushed
the
eng/Web-Inspector-Crash-when-inspecting-CSS-Grid-without-defined-columns-or-rows
branch
from
39e74ad
to
2eb0a35
Compare
|
EWS run on current version of this PR (hash 2eb0a35) |
… or rows https://bugs.webkit.org/show_bug.cgi?id=256072 rdar://108641874 Reviewed by Devin Rousso. 262869@main fixed issues with determining the authored grid track sizes, but in the process introduced a potential null pointer deref due to us erroneously trying to get a reference to a RefPtr's value instead of getting its pointer for use in a dynamic downcast. * LayoutTests/inspector/dom/showFlexOverlay.html: - Drive-by ensure we enable all options for flex overlays too so that those paths are exercises. * LayoutTests/inspector/dom/showGridOverlay.html: * Source/WebCore/inspector/InspectorOverlay.cpp: (WebCore::authoredGridTrackSizes): Canonical link: https://commits.webkit.org/263517@main
webkit-commit-queue
force-pushed
the
eng/Web-Inspector-Crash-when-inspecting-CSS-Grid-without-defined-columns-or-rows
branch
from
2eb0a35
to
05e01b5
Compare
|
Committed 263517@main (05e01b5): https://commits.webkit.org/263517@main Reviewed commits have been landed. Closing PR #13260 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
05e01b5
2eb0a35