Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResolutionMediaFeatureEnabled preference is a no-op #13281

Merged
merged 1 commit into from Apr 28, 2023
Merged

ResolutionMediaFeatureEnabled preference is a no-op #13281

merged 1 commit into from Apr 28, 2023

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Apr 28, 2023 •
edited by webkit-early-warning-system

2d54e17

ResolutionMediaFeatureEnabled preference is a no-op
https://bugs.webkit.org/show_bug.cgi?id=255447
rdar://108363296

Reviewed by Brent Fulgham.

> Since bug 248619 removed the (already dead) legacy media queries code, the ResolutionMediaFeatureEnabled setting has had no references within WebKit.
> While dropping this setting is probably fine, we shouldn't have the setting hang around while it does nothing.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/263519@main

c42867b

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@nt1m nt1m self-assigned this Apr 28, 2023
@nt1m nt1m added the CSS Cascading Style Sheets implementation label Apr 28, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c42867b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

brentfulgham
brentfulgham approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 28, 2023
@nt1m
ResolutionMediaFeatureEnabled preference is a no-op
2d54e17 
https://bugs.webkit.org/show_bug.cgi?id=255447
rdar://108363296

Reviewed by Brent Fulgham.

> Since bug 248619 removed the (already dead) legacy media queries code, the ResolutionMediaFeatureEnabled setting has had no references within WebKit.
> While dropping this setting is probably fine, we shouldn't have the setting hang around while it does nothing.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:

Canonical link: https://commits.webkit.org/263519@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263519@main (2d54e17): https://commits.webkit.org/263519@main

Reviewed commits have been landed. Closing PR #13281 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2d54e17 into WebKit:main Apr 28, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 28, 2023
@nt1m nt1m deleted the eng/rm-resolution-media-pref branch December 12, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@smfr smfr Awaiting requested review from smfr

@hortont424 hortont424 Awaiting requested review from hortont424

@patrickangle patrickangle Awaiting requested review from patrickangle

Assignees

@nt1m nt1m

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
4 participants
@nt1m @webkit-early-warning-system @webkit-commit-queue @brentfulgham