Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Flush deallocation log of the current thread in incremental sweeper #13346

Merged
merged 1 commit into from
May 2, 2023
Merged

[JSC] Flush deallocation log of the current thread in incremental sweeper #13346

merged 1 commit into from
May 2, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented May 2, 2023 •
edited by webkit-early-warning-system

9f05a2e

[JSC] Flush deallocation log of the current thread in incremental sweeper
https://bugs.webkit.org/show_bug.cgi?id=256188
rdar://108763314

Reviewed by Alexey Shvayka.

Running scavenger in sync is super costly, but flushing the current TLS cache of libpas would be reasonable
when it is idle. This patch does this in IncrementalSweeper.

* Source/JavaScriptCore/heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep):

Canonical link: https://commits.webkit.org/263601@main

62c7866

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner May 2, 2023 00:11
@Constellation Constellation self-assigned this May 2, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label May 2, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 62c7866)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

shvaikalesh
shvaikalesh approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@shvaikalesh shvaikalesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 2, 2023
@Constellation
[JSC] Flush deallocation log of the current thread in incremental swe…
9f05a2e 
…eper

https://bugs.webkit.org/show_bug.cgi?id=256188
rdar://108763314

Reviewed by Alexey Shvayka.

Running scavenger in sync is super costly, but flushing the current TLS cache of libpas would be reasonable
when it is idle. This patch does this in IncrementalSweeper.

* Source/JavaScriptCore/heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep):

Canonical link: https://commits.webkit.org/263601@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Flush-deallocation-log-of-the-current-thread-in-incremental-sweeper branch from 62c7866 to 9f05a2e Compare May 2, 2023 19:33
@webkit-commit-queue
Copy link
Collaborator

Committed 263601@main (9f05a2e): https://commits.webkit.org/263601@main

Reviewed commits have been landed. Closing PR #13346 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 9f05a2e into WebKit:main May 2, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shvaikalesh shvaikalesh shvaikalesh approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @shvaikalesh