Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION(263570@main) [Win] Connection.cpp: error C2121: '#': invalid character: possibly the result of a macro expansion #13356

Merged
merged 1 commit into from
May 2, 2023
Merged

REGRESSION(263570@main) [Win] Connection.cpp: error C2121: '#': invalid character: possibly the result of a macro expansion #13356

merged 1 commit into from
May 2, 2023

Conversation

fujii
Copy link
Contributor

@fujii fujii commented May 2, 2023 •
edited by webkit-early-warning-system

950330e

REGRESSION(263570@main) [Win] Connection.cpp: error C2121: '#': invalid character: possibly the result of a macro expansion
https://bugs.webkit.org/show_bug.cgi?id=256181

Unreviewed build fix for Windows port.

> WebKit/Platform/IPC/Connection.cpp(577): error C2121: '#': invalid character: possibly the result of a macro expansion

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessage):
Don't use #if in RELEASE_LOG_ERROR.

Canonical link: https://commits.webkit.org/263574@main

f9f1282

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@fujii fujii requested a review from cdumez as a code owner May 2, 2023 07:06
@fujii fujii self-assigned this May 2, 2023
@fujii fujii added the WebKit2 Bugs relating to the WebKit2 API layer label May 2, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f9f1282)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@fujii fujii added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 2, 2023
@fujii
REGRESSION(263570@main) [Win] Connection.cpp: error C2121: '#': inval…
950330e 
…id character: possibly the result of a macro expansion

https://bugs.webkit.org/show_bug.cgi?id=256181

Unreviewed build fix for Windows port.

> WebKit/Platform/IPC/Connection.cpp(577): error C2121: '#': invalid character: possibly the result of a macro expansion

* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessage):
Don't use #if in RELEASE_LOG_ERROR.

Canonical link: https://commits.webkit.org/263574@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263574@main (950330e): https://commits.webkit.org/263574@main

Reviewed commits have been landed. Closing PR #13356 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 950330e into WebKit:main May 2, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 2, 2023
@fujii fujii deleted the eng/bug-256181-fix-error-C2121 branch June 30, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@fujii fujii

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
3 participants
@fujii @webkit-early-warning-system @webkit-commit-queue