Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS Nesting] Add WPT for each nested at-rule #13358

Merged
merged 1 commit into from May 3, 2023
Merged

[CSS Nesting] Add WPT for each nested at-rule #13358

merged 1 commit into from May 3, 2023

Conversation

mdubet
Copy link
Contributor

@mdubet mdubet commented May 2, 2023 •
edited by webkit-early-warning-system

829f91f

[CSS Nesting] Add WPT for each nested at-rule
https://bugs.webkit.org/show_bug.cgi?id=256202
rdar://108776084

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules.html:

Canonical link: https://commits.webkit.org/263626@main

4b9c656

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mdubet mdubet self-assigned this May 2, 2023
@mdubet mdubet added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label May 2, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 95a74f6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@mdubet mdubet force-pushed the eng/css-nesting-WPT-for-nested-at-rules-layer--- branch from 95a74f6 to 4b9c656 Compare May 3, 2023 07:31
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 4b9c656)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mdubet mdubet added the merge-queue Applied to send a pull request to merge-queue label May 3, 2023
@mdubet
[CSS Nesting] Add WPT for each nested at-rule
829f91f 
https://bugs.webkit.org/show_bug.cgi?id=256202
rdar://108776084

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-expected.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules-ref.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-nesting/conditional-rules.html:

Canonical link: https://commits.webkit.org/263626@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/css-nesting-WPT-for-nested-at-rules-layer--- branch from 4b9c656 to 829f91f Compare May 3, 2023 09:46
@webkit-commit-queue
Copy link
Collaborator

Committed 263626@main (829f91f): https://commits.webkit.org/263626@main

Reviewed commits have been landed. Closing PR #13358 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 829f91f into WebKit:main May 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@mdubet mdubet

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
4 participants
@mdubet @webkit-early-warning-system @webkit-commit-queue @nt1m