Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label elements should get InteractionRegions when associated to a control #13380

Merged
merged 1 commit into from May 3, 2023

Conversation

etiennesegonzac
Copy link
Contributor

@etiennesegonzac etiennesegonzac commented May 2, 2023

8c684cf

Label elements should get InteractionRegions when associated to a control
https://bugs.webkit.org/show_bug.cgi?id=256234
<rdar://108739137>

Reviewed by Tim Horton.

Add support for `<label>` elements in the InteractionRegion generation
code.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
When an element is "labelable", look for label ancestors when doing
element matching.
When a label has a control associated, remove the `cursor: pointer`
requirement, like we do for the control itself.
Group label and control together by using the control's
`elementIndentifier` for both regions.

* LayoutTests/interaction-region/labels-expected.txt: Added.
* LayoutTests/interaction-region/labels.html: Added.
Add a new test file for labels.

Canonical link: https://commits.webkit.org/263621@main

2d8b7b4

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@etiennesegonzac etiennesegonzac self-assigned this May 2, 2023
@etiennesegonzac etiennesegonzac added the Layout and Rendering For bugs with layout and rendering of Web pages. label May 2, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 3, 2023
@etiennesegonzac etiennesegonzac added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 3, 2023
…trol

https://bugs.webkit.org/show_bug.cgi?id=256234
<rdar://108739137>

Reviewed by Tim Horton.

Add support for `<label>` elements in the InteractionRegion generation
code.

* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::interactionRegionForRenderedRegion):
When an element is "labelable", look for label ancestors when doing
element matching.
When a label has a control associated, remove the `cursor: pointer`
requirement, like we do for the control itself.
Group label and control together by using the control's
`elementIndentifier` for both regions.

* LayoutTests/interaction-region/labels-expected.txt: Added.
* LayoutTests/interaction-region/labels.html: Added.
Add a new test file for labels.

Canonical link: https://commits.webkit.org/263621@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263621@main (8c684cf): https://commits.webkit.org/263621@main

Reviewed commits have been landed. Closing PR #13380 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8c684cf into WebKit:main May 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
5 participants