Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git-webkit] Use shared commit issue parsing in 'trace' #13382

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented May 2, 2023

c0ccf9b

[git-webkit] Use shared commit issue parsing in 'trace'
https://bugs.webkit.org/show_bug.cgi?id=256236
rdar://108816711

Reviewed by Aakash Jain.

Prefer the shared commits.issues implementation instead of re-implementing
similar code within CommitsStory.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/trace.py:
(CommitsStory.add): Use commits.issues.
(Trace.relationships): Ditto.
(CommitsStory.issues_for): Deleted.

Canonical link: https://commits.webkit.org/263685@main

9e77b6c

Misc iOS, tvOS & watchOS macOS Linux Windows
  πŸ§ͺ style   πŸ›  ios   πŸ›  mac   πŸ›  wpe   πŸ›  wincairo
  πŸ§ͺ bindings   πŸ›  ios-sim   πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
  πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ›  gtk
  πŸ§ͺ webkitpy   πŸ§ͺ ios-wk2-wpt   πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
  πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2
  πŸ§ͺ services   πŸ›  tv-sim   πŸ§ͺ mac-wk2-stress
  πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge   πŸ›  watch-sim

@JonWBedard JonWBedard self-assigned this May 2, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 2, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 3, 2023
@JonWBedard JonWBedard removed the merging-blocked Applied to prevent a change from being merged label May 3, 2023
@JonWBedard JonWBedard force-pushed the eng/git-webkit-Use-shared-commit-issue-parsing-in-trace branch from f7dbd97 to eb6480a Compare May 3, 2023 18:39
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@JonWBedard JonWBedard force-pushed the eng/git-webkit-Use-shared-commit-issue-parsing-in-trace branch from eb6480a to 9e77b6c Compare May 4, 2023 18:09
@JonWBedard JonWBedard added skip-ews Applied to prevent a change from being run on EWS unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 4, 2023
https://bugs.webkit.org/show_bug.cgi?id=256236
rdar://108816711

Reviewed by Aakash Jain.

Prefer the shared commits.issues implementation instead of re-implementing
similar code within CommitsStory.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/trace.py:
(CommitsStory.add): Use commits.issues.
(Trace.relationships): Ditto.
(CommitsStory.issues_for): Deleted.

Canonical link: https://commits.webkit.org/263685@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/git-webkit-Use-shared-commit-issue-parsing-in-trace branch from 9e77b6c to c0ccf9b Compare May 4, 2023 18:13
@webkit-commit-queue
Copy link
Collaborator

Committed 263685@main (c0ccf9b): https://commits.webkit.org/263685@main

Reviewed commits have been landed. Closing PR #13382 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c0ccf9b into WebKit:main May 4, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 4, 2023
@JonWBedard JonWBedard deleted the eng/git-webkit-Use-shared-commit-issue-parsing-in-trace branch May 4, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ews Applied to prevent a change from being run on EWS Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants