ASSERTION FAILED: isMainRunLoop() under RemoteRenderingBackend::releaseRemoteGPU() #13416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o run in the background https://bugs.webkit.org/show_bug.cgi?id=256259 rdar://103388697 Reviewed by NOBODY (OOPS!). If a page changes its title while in the background, allow the page to run in the background, as long as the app is foreground. Previously, the page changing its title would buy its an extra 8 minutes of background running time. We are now more permissive and allow the page to run indefinitely in the background when we detect this (as long as the application is foreground). * Source/WebKit/UIProcess/ProcessThrottler.cpp: (WebKit::ProcessThrottler::ProcessThrottler): (WebKit::ProcessThrottler::dropSuspendedAssertionTimerFired): (WebKit::ProcessThrottler::pageAllowedToRunInTheBackgroundToken): (WebKit::ProcessThrottler::numberOfPagesAllowedToRunInTheBackgroundChanged): (WebKit::ProcessThrottler::delaySuspension): Deleted. * Source/WebKit/UIProcess/ProcessThrottler.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::ProcessActivityState::reset): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::didReceiveTitleForFrame): (WebKit::WebPageProxy::resetStateAfterProcessExited): (WebKit::WebPageProxy::pageWillLikelyUseNotifications): (WebKit::WebPageProxy::showNotification): (WebKit::WebPageProxy::ProcessActivityState::takeLikelyToUseNotificationsActivity): Deleted. (WebKit::WebPageProxy::ProcessActivityState::dropLikelyToUseNotificationsActivity): Deleted. * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxyInternals.h:
…seRemoteGPU() https://bugs.webkit.org/show_bug.cgi?id=256272 Reviewed by NOBODY (OOPS!). RemoteRenderingBackend::releaseRemoteGPU() runs off the main thread and was calling tryExitIfUnusedAndUnderMemoryPressure() on this same thread, which wasn't safe and would hit an assertion in debug. Make sure we dispatch to the main thread before calling tryExitIfUnusedAndUnderMemoryPressure(). * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::releaseRemoteGPU):
|
Messed up my branches. now tracked by #13417. |
|
EWS run on current version of this PR (hash 5bdeed8)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5bdeed8
6e30f36
5bdeed8
🧪 style🛠 ios🛠 mac🛠 wpe🛠 wincairo🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🛠 gtk🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 tv-sim🧪 mac-wk2-stress🛠 watch🛠 watch-sim