[Cocoa] [Shape Detection] WebKit crashes on launch when on the base system #13428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 8685276) |
pxlcoder
approved these changes
May 4, 2023
pxlcoder
reviewed
May 4, 2023
Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm
Outdated
Show resolved
Hide resolved
|
I'll update the copyrights before landing. |
litherum
force-pushed
the
eng/Cocoa-Shape-Detection-WebKit-crashes-on-launch-when-on-the-base-system
branch
from
8685276
to
92e5526
Compare
|
EWS run on previous version of this PR (hash 92e5526) |
litherum
force-pushed
the
eng/Cocoa-Shape-Detection-WebKit-crashes-on-launch-when-on-the-base-system
branch
from
92e5526
to
d20224c
Compare
|
EWS run on current version of this PR (hash d20224c) |
…ystem https://bugs.webkit.org/show_bug.cgi?id=256287 rdar://108870362 Reviewed by Aditya Keerthi. Turns out the base system doesn't have Vision.framework or CoreML.framework. We were crashing because we were statically linking with CoreML.framework. This patch makes us use soft linking instead. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/VisionUtilities.mm: (WebCore::ShapeDetection::configureRequestToUseCPUOrGPU): * Source/WebCore/PAL/pal/cocoa/CoreMLSoftLink.h: * Source/WebCore/PAL/pal/cocoa/CoreMLSoftLink.mm: * Source/WebCore/PAL/pal/cocoa/VisionSoftLink.h: * Source/WebCore/PAL/pal/cocoa/VisionSoftLink.mm: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/263661@main
webkit-commit-queue
force-pushed
the
eng/Cocoa-Shape-Detection-WebKit-crashes-on-launch-when-on-the-base-system
branch
from
d20224c
to
fcedcb7
Compare
|
Committed 263661@main (fcedcb7): https://commits.webkit.org/263661@main Reviewed commits have been landed. Closing PR #13428 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
litherum
deleted the
eng/Cocoa-Shape-Detection-WebKit-crashes-on-launch-when-on-the-base-system
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fcedcb7
d20224c
🛠 wincairo🧪 wpe-wk2🧪 gtk-wk2🛠 🧪 jsc🧪 mac-AS-debug-wk2