New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU Process] [Filters 22/23] Cache the SVGFilter applying results in RemoteResourceCache #13432
Closed
shallawa
wants to merge
1
commit into
WebKit:main
from
shallawa:eng/GPU-Process-Filters-2223-Cache-the-filter-applying-results-in-RemoteResourceCache
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shallawa
added
the
Layout and Rendering
For bugs with layout and rendering of Web pages.
label
May 4, 2023
EWS run on previous version of this PR (hash 0502b33) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 4, 2023
β¦ RemoteResourceCache https://bugs.webkit.org/show_bug.cgi?id=232845 rdar://85426641 Reviewed by NOBODY (OOPS!). This allows caching the results of applying an SVGFilter to a source ImageBuffer in GPU Process. We should be able to use the result if the Filter was not changed. We should be also able to clear some of the result FilterImages if a FilterEffect was changed. * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/DecomposedGlyphs.h: * Source/WebCore/platform/graphics/Gradient.h: * Source/WebCore/platform/graphics/ImageBufferAllocator.h: * Source/WebCore/platform/graphics/NativeImage.h: * Source/WebCore/platform/graphics/RenderingResource.h: (WebCore::RenderingResource::renderingResourceIdentifierIfExists const): * Source/WebCore/platform/graphics/displaylists/DisplayList.h: (WebCore::DisplayList::DisplayList::cacheSVGFilter): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::drawFilteredImageBuffer): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h: * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp: (WebCore::DisplayList::RecorderImpl::recordResourceUse): * Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h: * Source/WebCore/platform/graphics/displaylists/DisplayListResourceHeap.h: (WebCore::DisplayList::LocalResourceHeap::add): * Source/WebCore/platform/graphics/filters/FilterFunction.h: * Source/WebCore/platform/graphics/filters/FilterResults.h: * Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp: (WebCore::RenderSVGResourceFilter::applyResource): (WebCore::RenderSVGResourceFilter::markFilterForRepaint): * Source/WebCore/rendering/svg/RenderSVGResourceFilter.h: * Source/WebCore/svg/graphics/filters/SVGFilter.cpp: (WebCore::SVGFilter::create): (WebCore::SVGFilter::SVGFilter): (WebCore::SVGFilter::buildExpression): (WebCore::SVGFilter::supportedFilterRenderingModes const): (WebCore::SVGFilter::effectsOfType const): (WebCore::SVGFilter::ensureResults): (WebCore::SVGFilter::addToTransaction): (WebCore::SVGFilter::buildTransaction): (WebCore::SVGFilter::applyTransaction): (WebCore::SVGFilter::apply): (WebCore::SVGFilter::createFilterStyles const): (WebCore::SVGFilter::externalRepresentation const): * Source/WebCore/svg/graphics/filters/SVGFilter.h: * Source/WebCore/svg/graphics/filters/SVGFilterExpression.h: * Source/WebCore/svg/graphics/filters/SVGFilterGraph.h: (WebCore::SVGFilterGraph::SVGFilterGraph): (WebCore::SVGFilterGraph::nodes const): * Source/WebCore/svg/graphics/filters/SVGFilterTransaction.h: Renamed from Source/WebCore/svg/graphics/filters/SVGFilterExpressionReference.h. * Source/WebKit/GPUProcess/graphics/QualifiedResourceHeap.h: (WebKit::QualifiedResourceHeap::add): (WebKit::QualifiedResourceHeap::getSVGFilter const): (WebKit::QualifiedResourceHeap::removeSVGFilter): (WebKit::QualifiedResourceHeap::releaseAllResources): (WebKit::QualifiedResourceHeap::checkInvariants const): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp: (WebKit::RemoteDisplayListRecorder::drawFilteredImageBufferInternal): (WebKit::RemoteDisplayListRecorder::drawFilteredImageBuffer): (WebKit::RemoteDisplayListRecorder::drawSVGFilteredImageBuffer): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h: * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::cacheSVGFilter): (WebKit::RemoteRenderingBackend::cacheSVGFilterWithQualifiedIdentifier): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteResourceCache.cpp: (WebKit::RemoteResourceCache::cacheSVGFilter): (WebKit::RemoteResourceCache::cachedSVGFilter const): (WebKit::RemoteResourceCache::releaseRenderingResource): * Source/WebKit/GPUProcess/graphics/RemoteResourceCache.h: * Source/WebKit/Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<CSSFilter>::encode): (IPC::ArgumentCoder<CSSFilter>::decode): (IPC::ArgumentCoder<SVGFilter>::encode): (IPC::ArgumentCoder<SVGFilter>::decode): (IPC::ArgumentCoder<Filter>::encodeFilterProperties): (IPC::ArgumentCoder<Filter>::decodeFilterProperties): (IPC::ArgumentCoder<Filter>::encode): (IPC::ArgumentCoder<Filter>::decode): * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp: (WebKit::RemoteDisplayListRecorderProxy::recordDrawFilteredImageBuffer): (WebKit::RemoteDisplayListRecorderProxy::recordResourceUse): * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::cacheSVGFilter): * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: * Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.cpp: (WebKit::RemoteResourceCacheProxy::~RemoteResourceCacheProxy): (WebKit::RemoteResourceCacheProxy::clear): (WebKit::RemoteResourceCacheProxy::recordSVGFilterUse): (WebKit::RemoteResourceCacheProxy::releaseRenderingResource): (WebKit::RemoteResourceCacheProxy::clearGradientMap): (WebKit::RemoteResourceCacheProxy::clearSVGFilterMap): (WebKit::RemoteResourceCacheProxy::remoteResourceCacheWasDestroyed): (WebKit::RemoteResourceCacheProxy::releaseMemory): * Source/WebKit/WebProcess/GPU/graphics/RemoteResourceCacheProxy.h:
shallawa
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 4, 2023
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 4, 2023
shallawa
force-pushed
the
eng/GPU-Process-Filters-2223-Cache-the-filter-applying-results-in-RemoteResourceCache
branch
from
May 4, 2023 03:46
0502b33
to
a59ad65
Compare
EWS run on current version of this PR (hash a59ad65) |
This patch has been split into smaller patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Layout and Rendering
For bugs with layout and rendering of Web pages.
merging-blocked
Applied to prevent a change from being merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a59ad65
a59ad65