Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cocoa] Rename FontCustomPlatformDataMac to FontCustomPlatformDataCoreText #13472

Merged
merged 1 commit into from
May 5, 2023
Merged

[Cocoa] Rename FontCustomPlatformDataMac to FontCustomPlatformDataCoreText #13472

merged 1 commit into from
May 5, 2023

Conversation

litherum
Copy link
Contributor

@litherum litherum commented May 5, 2023 •
edited by webkit-early-warning-system

237442d

[Cocoa] Rename FontCustomPlatformDataMac to FontCustomPlatformDataCoreText
https://bugs.webkit.org/show_bug.cgi?id=256345
rdar://108924213

Reviewed by Tim Nguyen.

The code in this file uses Core Text, instead of anything macOS-specific.

* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/coretext/FontCustomPlatformDataCoreText.cpp: Renamed from Source/WebCore/platform/graphics/mac/FontCustomPlatformDataMac.cpp.
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):

Canonical link: https://commits.webkit.org/263706@main

c7031cb

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@litherum litherum self-assigned this May 5, 2023
@litherum litherum added the Text For bugs in text layout and rendering, including international text support. label May 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 59fcb9f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios   🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
⏳ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
  🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
⏳ 🧪 webkitpy ❌ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ❌ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 5, 2023
@litherum litherum removed the merging-blocked Applied to prevent a change from being merged label May 5, 2023
@litherum litherum force-pushed the eng/Cocoa-Rename-FontCustomPlatformDataMac-to-FontCustomPlatformDataCoreText branch from 59fcb9f to c7031cb Compare May 5, 2023 00:45
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c7031cb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ⏳ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@litherum litherum requested a review from nt1m May 5, 2023 00:49
@litherum litherum added the merge-queue Applied to send a pull request to merge-queue label May 5, 2023
@litherum
[Cocoa] Rename FontCustomPlatformDataMac to FontCustomPlatformDataCor…
237442d 
…eText

https://bugs.webkit.org/show_bug.cgi?id=256345
rdar://108924213

Reviewed by Tim Nguyen.

The code in this file uses Core Text, instead of anything macOS-specific.

* Source/WebCore/PlatformMac.cmake:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/graphics/coretext/FontCustomPlatformDataCoreText.cpp: Renamed from Source/WebCore/platform/graphics/mac/FontCustomPlatformDataMac.cpp.
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):

Canonical link: https://commits.webkit.org/263706@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Cocoa-Rename-FontCustomPlatformDataMac-to-FontCustomPlatformDataCoreText branch from c7031cb to 237442d Compare May 5, 2023 02:39
@webkit-commit-queue
Copy link
Collaborator

Committed 263706@main (237442d): https://commits.webkit.org/263706@main

Reviewed commits have been landed. Closing PR #13472 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 237442d into WebKit:main May 5, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 5, 2023
@litherum litherum deleted the eng/Cocoa-Rename-FontCustomPlatformDataMac-to-FontCustomPlatformDataCoreText branch May 5, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@litherum litherum

Labels
Text For bugs in text layout and rendering, including international text support.
Projects
None yet
Milestone
No milestone
5 participants
@litherum @webkit-early-warning-system @webkit-commit-queue @nt1m @webkit-ews-buildbot