Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge LocalFrameView::layoutOrVisualViewportChanged into LocalFrameView::updateLayoutViewport #13487

Closed
wants to merge 1 commit into from
Closed

Merge LocalFrameView::layoutOrVisualViewportChanged into LocalFrameView::updateLayoutViewport #13487

wants to merge 1 commit into from

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented May 5, 2023 •
edited by webkit-early-warning-system

7b1c4ea

Merge LocalFrameView::layoutOrVisualViewportChanged into LocalFrameView::updateLayoutViewport
https://bugs.webkit.org/show_bug.cgi?id=256355

Reviewed by NOBODY (OOPS!).

Merged LocalFrameView::layoutOrVisualViewportChanged into LocalFrameView::updateLayoutViewport.

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateLayoutViewport):
(WebCore::LocalFrameView::layoutOrVisualViewportChanged): Deleted.
* Source/WebCore/page/LocalFrameView.h:

7b1c4ea

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
  🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
❌ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
❌ 🛠 tv   🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@rniwa
Merge LocalFrameView::layoutOrVisualViewportChanged into LocalFrameVi…
7b1c4ea 
…ew::updateLayoutViewport

https://bugs.webkit.org/show_bug.cgi?id=256355

Reviewed by NOBODY (OOPS!).

Merged LocalFrameView::layoutOrVisualViewportChanged into LocalFrameView::updateLayoutViewport.

* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::updateLayoutViewport):
(WebCore::LocalFrameView::layoutOrVisualViewportChanged): Deleted.
* Source/WebCore/page/LocalFrameView.h:
@rniwa rniwa requested a review from cdumez as a code owner May 5, 2023 06:27
@rniwa rniwa self-assigned this May 5, 2023
@rniwa rniwa added the Layout and Rendering For bugs with layout and rendering of Web pages. label May 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7b1c4ea)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
  🧪 bindings ❌ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
❌ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
❌ 🛠 tv   🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim
❌ 🛠 watch
❌ 🛠 watch-sim

@rniwa
Copy link
Member Author

rniwa commented May 5, 2023

Oh, I missed the usage in iOS WebKit2.

@rniwa rniwa closed this May 5, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@anttijk anttijk Awaiting requested review from anttijk

@alanbaradlay alanbaradlay Awaiting requested review from alanbaradlay

@smfr smfr Awaiting requested review from smfr

Assignees

@rniwa rniwa

Labels
Layout and Rendering For bugs with layout and rendering of Web pages. merging-blocked Applied to prevent a change from being merged
Projects
None yet
Milestone
No milestone
3 participants
@rniwa @webkit-early-warning-system @webkit-ews-buildbot