New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list of supported font-formats at parse time (256313) #13513
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
vitorroriz:fix-font-face-format
May 10, 2023
Merged
Fix list of supported font-formats at parse time (256313) #13513
webkit-commit-queue
merged 1 commit into
WebKit:main
from
vitorroriz:fix-font-face-format
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash d7e49b7) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 5, 2023
vitorroriz
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 8, 2023
vitorroriz
force-pushed
the
fix-font-face-format
branch
from
May 8, 2023 16:48
d7e49b7
to
5c09c3f
Compare
EWS run on previous version of this PR (hash 5c09c3f) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 8, 2023
vitorroriz
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 10, 2023
vitorroriz
force-pushed
the
fix-font-face-format
branch
from
May 10, 2023 11:19
5c09c3f
to
2651178
Compare
EWS run on current version of this PR (hash 2651178) |
litherum
approved these changes
May 10, 2023
https://bugs.webkit.org/show_bug.cgi?id=256313 rdar://108897052 Reviewed by Myles C. Maxfield. We are now rejecting unsupported formats at parsing time. We are also moving the code fragment that parses the font-format to its own function, so it can be used by both @font-face src and @supports parsers. * LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-format-expected.txt: * Source/WebCore/css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcResourceValue::fontLoadRequest): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeFontFormat): (WebCore::CSSPropertyParserHelpers::identMatchesSupportedFontFormat): Deleted. * Source/WebCore/css/parser/CSSPropertyParserHelpers.h: * Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI): * Source/WebCore/css/parser/CSSSupportsParser.cpp: (WebCore::CSSSupportsParser::consumeSupportsFontFormatFunction): * Source/WebCore/platform/graphics/coretext/FontCustomPlatformDataCoreText.cpp: (WebCore::FontCustomPlatformData::supportsFormat): * Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: (WebCore::FontCustomPlatformData::supportsFormat): * Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp: (WebCore::FontCustomPlatformData::supportsFormat): Canonical link: https://commits.webkit.org/263914@main
webkit-commit-queue
force-pushed
the
fix-font-face-format
branch
from
May 10, 2023 18:02
2651178
to
0a0261e
Compare
Committed 263914@main (0a0261e): https://commits.webkit.org/263914@main Reviewed commits have been landed. Closing PR #13513 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0a0261e
2651178