Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer][MSE] Decoder sometimes receives caps event before stream-start #13548

Merged
merged 1 commit into from
May 8, 2023
Merged

[GStreamer][MSE] Decoder sometimes receives caps event before stream-start #13548

merged 1 commit into from
May 8, 2023

Conversation

philn
Copy link
Member

@philn philn commented May 7, 2023 •
edited by webkit-early-warning-system

c49bd91

[GStreamer][MSE] Decoder sometimes receives caps event before stream-start
https://bugs.webkit.org/show_bug.cgi?id=256428

Reviewed by Xabier Rodriguez-Calvar.

Warn about caps event reaching the video decoder before stream-start. This is a temporary workaround
for broken behaviour of the playbin3/webkitmediasource combo.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setupCodecProbe):

Canonical link: https://commits.webkit.org/263791@main

583bb24

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this May 7, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label May 7, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 583bb24)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn requested a review from calvaris May 7, 2023 10:19
@philn philn added the merge-queue Applied to send a pull request to merge-queue label May 8, 2023
@philn
[GStreamer][MSE] Decoder sometimes receives caps event before stream-…
c49bd91 
…start

https://bugs.webkit.org/show_bug.cgi?id=256428

Reviewed by Xabier Rodriguez-Calvar.

Warn about caps event reaching the video decoder before stream-start. This is a temporary workaround
for broken behaviour of the playbin3/webkitmediasource combo.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setupCodecProbe):

Canonical link: https://commits.webkit.org/263791@main
@webkit-commit-queue
Copy link
Collaborator

Committed 263791@main (c49bd91): https://commits.webkit.org/263791@main

Reviewed commits have been landed. Closing PR #13548 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c49bd91 into WebKit:main May 8, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 8, 2023
@philn philn deleted the eng/256428 branch May 8, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvaris calvaris calvaris approved these changes

Assignees

@philn philn

Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
Milestone
No milestone
4 participants
@philn @webkit-early-warning-system @webkit-commit-queue @calvaris