Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (251295@main): -[WKWebInspectorUISaveController initWithSaveDatas:savePanel:] leaks an NSView #13561

Merged
merged 1 commit into from May 8, 2023
Merged

REGRESSION (251295@main): -[WKWebInspectorUISaveController initWithSaveDatas:savePanel:] leaks an NSView #13561

merged 1 commit into from May 8, 2023

Conversation

ddkilzer
Copy link
Contributor

@ddkilzer ddkilzer commented May 8, 2023 •
edited by webkit-early-warning-system

e6f69b4

REGRESSION (251295@main): -[WKWebInspectorUISaveController initWithSaveDatas:savePanel:] leaks an NSView
https://bugs.webkit.org/show_bug.cgi?id=256440
<rdar://109023427>

Reviewed by Devin Rousso.

* Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:
(-[WKWebInspectorUISaveController initWithSaveDatas:savePanel:]):
- Use adoptNS().get() to fix the leak.

Canonical link: https://commits.webkit.org/263787@main

a36f358

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer requested a review from cdumez as a code owner May 8, 2023 03:48
@ddkilzer ddkilzer self-assigned this May 8, 2023
@ddkilzer ddkilzer added the Web Inspector Bugs related to the WebKit Web Inspector. label May 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a36f358)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@ddkilzer ddkilzer requested a review from patrickangle May 8, 2023 03:50
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 8, 2023
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label May 8, 2023
@ddkilzer ddkilzer added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 8, 2023
@ddkilzer
REGRESSION (251295@main): -[WKWebInspectorUISaveController initWithSa…
e6f69b4 
…veDatas:savePanel:] leaks an NSView

https://bugs.webkit.org/show_bug.cgi?id=256440
<rdar://109023427>

Reviewed by Devin Rousso.

* Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:
(-[WKWebInspectorUISaveController initWithSaveDatas:savePanel:]):
- Use adoptNS().get() to fix the leak.

Canonical link: https://commits.webkit.org/263787@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-251295main--WKWebInspectorUISaveController-initWithSaveDatassavePanel-leaks-an-NSView branch from a36f358 to e6f69b4 Compare May 8, 2023 08:22
@webkit-commit-queue
Copy link
Collaborator

Committed 263787@main (e6f69b4): https://commits.webkit.org/263787@main

Reviewed commits have been landed. Closing PR #13561 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e6f69b4 into WebKit:main May 8, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 8, 2023
@ddkilzer ddkilzer deleted the eng/REGRESSION-251295main--WKWebInspectorUISaveController-initWithSaveDatassavePanel-leaks-an-NSView branch May 8, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcrousso dcrousso dcrousso approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@patrickangle patrickangle Awaiting requested review from patrickangle

Assignees

@ddkilzer ddkilzer

Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
Milestone
No milestone
6 participants
@ddkilzer @webkit-early-warning-system @webkit-commit-queue @dcrousso @nt1m @webkit-ews-buildbot